https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2018-01-19T21:31:48Z
Ruby Issue Tracking System
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69641
2018-01-19T21:31:48Z
MSP-Greg (Greg L)
<ul><li><strong>File</strong> <i>chmod_umask.patch</i> added</li><li><strong>File</strong> <a href="/attachments/6963">chmod_spec.rb</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6963/chmod_spec.rb">chmod_spec.rb</a> added</li><li><strong>File</strong> <i>umask_spec.rb</i> added</li></ul><p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/772">@Eregon (Benoit Daloze)</a>,</p>
<p>Attached are three files (one patch, and two spec files from repo). Changes allow it to pass on MinGW. Rearranged things, not sure if that's appropriate (or done correctly)...</p>
<p>Thanks, Greg</p>
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69642
2018-01-19T21:34:25Z
MSP-Greg (Greg L)
<ul><li><strong>Subject</strong> changed from <i>3 Spec failures building MinGW 2018-01-20 trunk 61964</i> to <i>3 Spec failures building MinGW 2018-01-19 trunk 61950</i></li><li><strong>ruby -v</strong> changed from <i>ruby 2.6.0dev (2018-01-20 trunk 61964) [x64-mingw32]</i> to <i>ruby 2.6.0dev (2018-01-19 trunk 61950) [x64-mingw32]</i></li></ul>
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69645
2018-01-20T03:50:16Z
MSP-Greg (Greg L)
<ul><li><strong>File</strong> deleted (<del><i>chmod_umask.patch</i></del>)</li></ul>
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69646
2018-01-20T03:50:21Z
MSP-Greg (Greg L)
<ul><li><strong>File</strong> deleted (<del><i>umask_spec.rb</i></del>)</li></ul>
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69647
2018-01-20T03:51:18Z
MSP-Greg (Greg L)
<ul><li><strong>File</strong> <a href="/attachments/6969">spec-ruby-core-file-chmod_umask.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6969/spec-ruby-core-file-chmod_umask.patch">spec-ruby-core-file-chmod_umask.patch</a> added</li><li><strong>File</strong> <a href="/attachments/6970">umask_spec.rb</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6970/umask_spec.rb">umask_spec.rb</a> added</li></ul>
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69658
2018-01-20T15:41:06Z
MSP-Greg (Greg L)
<ul></ul><p>Please ignore the above files. Patch is located at <a href="https://github.com/MSP-Greg/ruby-loco/blob/498b640b81d798c8d69badb7f24738b977caad00/patches/gte20600/spec-ruby-core-file-chmod_umask.patch" class="external">https://github.com/MSP-Greg/ruby-loco/blob/498b640b81d798c8d69badb7f24738b977caad00/patches/gte20600/spec-ruby-core-file-chmod_umask.patch</a> or <a href="https://raw.githubusercontent.com/MSP-Greg/ruby-loco/498b640b81d798c8d69badb7f24738b977caad00/patches/gte20600/spec-ruby-core-file-chmod_umask.patch" class="external">https://raw.githubusercontent.com/MSP-Greg/ruby-loco/498b640b81d798c8d69badb7f24738b977caad00/patches/gte20600/spec-ruby-core-file-chmod_umask.patch</a>.</p>
<p>This was applied for current ruby-loco builds, and the builds pass spec tests.</p>
<p>Thanks, Greg</p>
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69668
2018-01-21T17:18:24Z
Eregon (Benoit Daloze)
<ul><li><strong>Assignee</strong> set to <i>Eregon (Benoit Daloze)</i></li></ul><p>Thanks for the report, I'll take a look.<br>
This spec looks rather hacky at first sight.</p>
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69818
2018-01-25T09:50:33Z
Eregon (Benoit Daloze)
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset trunk|r62036.</p>
<hr>
<p>Remove specs trying arbitrary values for chmod and umask</p>
<ul>
<li>Instead assert that too large values raise RangeError.</li>
<li>[Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: 3 Spec failures building MinGW 2018-01-19 trunk 61950 (Closed)" href="https://redmine.ruby-lang.org/issues/14375">#14375</a>] <a href="/issues/14375">[ruby-core:84933]</a></li>
<li>See <a href="https://github.com/ruby/ruby/pull/1797" class="external">https://github.com/ruby/ruby/pull/1797</a>
</li>
</ul>
Ruby master - Bug #14375: 3 Spec failures building MinGW 2018-01-19 trunk 61950
https://redmine.ruby-lang.org/issues/14375?journal_id=69819
2018-01-25T09:55:56Z
Eregon (Benoit Daloze)
<ul></ul><p>Thank you for the report and patches.</p>
<p>I decided to remove the specs trying arbitrary values for chmod/umask in r62036.<br>
So much platform guards is usually a sign we are testing OS/libc-level stuff, which is not really the right thing for ruby/spec (we should test common real-world cases instead).</p>