Project

General

Profile

Actions

Feature #13508

closed

How remove/refactor code related mathn library.

Feature #13508: How remove/refactor code related mathn library.

Added by hsbt (Hiroshi SHIBATA) about 9 years ago. Updated 3 days ago.

Status:
Closed
Target version:
-
[ruby-core:80858]

Description

I removed mathn library at r58413 and r58432.

I have some concerns related mathn library. This issue is reminder for this concern.

  1. Still remains conditions for mathn loaded. ex. https://github.com/ruby/ruby/blob/trunk/array.c#L5755
  2. {complex,rational}.c have {nucomp,nurat}_canonicalization methods for mathn.
  3. lib/cmath.rb have workaround code for mathn see. https://github.com/ruby/ruby/blob/trunk/lib/cmath.rb#L27

I continue to discuss concerns to @mrkn (Kenta Murata)

Updated by shyouhei (Shyouhei Urabe) about 9 years ago Actions #1

  • Status changed from Open to Assigned

Updated by hsbt (Hiroshi SHIBATA) over 8 years ago Actions #2 [ruby-core:84232]

  • Target version changed from 2.5 to 2.6

I gave up to apply at Ruby 2.5. I try this next year.

Updated by naruse (Yui NARUSE) over 8 years ago Actions #3

  • Target version deleted (2.6)

Updated by hsbt (Hiroshi SHIBATA) 3 days ago Actions #4 [ruby-core:125717]

  • Status changed from Assigned to Closed

All the items in this ticket have been resolved.

The mathn-specific code in array.c, complex.c, rational.c and enum.c was removed at https://github.com/ruby/ruby/commit/b958e2add835d62c0a62edaf9a23ecbbd70a3635 (https://github.com/ruby/ruby/pull/3691), and the obsolete --enable-mathn configure option was removed at https://github.com/ruby/ruby/commit/89110b27437d4a84f7cb0387e59fd40d94efee1d.

lib/cmath.rb was removed from the ruby repository at https://github.com/ruby/ruby/commit/a3b85016149f4f73f08c739626b2f02badd5ad17. The mathn workaround remaining in the cmath gem is intentionally kept for compatibility with the mathn gem.

Actions

Also available in: PDF Atom