Project

General

Profile

Bug #12908

make-snapshot is broken

Added by vo.x (Vit Ondruch) about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:78036]

Description

Testing with r56663, the make-snapshot fails with message:

$ tool/make-snapshot -packages=xz tmp
/builddir/ruby/tool/vcs.rb:123:in `realpath': no implicit conversion of URI::HTTP into String (TypeError)
    from /builddir/ruby/tool/vcs.rb:123:in `initialize'
    from tool/make-snapshot:416:in `new'
    from tool/make-snapshot:416:in `<main>'

It does not work since r56638, although the error was different initially.


Related issues

Related to Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-styleClosedActions

Associated revisions

Revision 5443a9fd
Added by nobu (Nobuyoshi Nakada) about 3 years ago

vcs.rb: fix srcdir in VCS::GIT

  • tool/vcs.rb (VCS::GIT.cmd_args): add chdir option to arguments for IO.popen if srcdir is a local path. unless -srcdir command line option is given, srcdir is the default URL. [ruby-core:78036] [Bug #12908]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56668 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 56668
Added by nobu (Nobuyoshi Nakada) about 3 years ago

vcs.rb: fix srcdir in VCS::GIT

  • tool/vcs.rb (VCS::GIT.cmd_args): add chdir option to arguments for IO.popen if srcdir is a local path. unless -srcdir command line option is given, srcdir is the default URL. [ruby-core:78036] [Bug #12908]

Revision 56668
Added by nobu (Nobuyoshi Nakada) about 3 years ago

vcs.rb: fix srcdir in VCS::GIT

  • tool/vcs.rb (VCS::GIT.cmd_args): add chdir option to arguments for IO.popen if srcdir is a local path. unless -srcdir command line option is given, srcdir is the default URL. [ruby-core:78036] [Bug #12908]

Revision 56668
Added by nobu (Nobuyoshi Nakada) about 3 years ago

vcs.rb: fix srcdir in VCS::GIT

  • tool/vcs.rb (VCS::GIT.cmd_args): add chdir option to arguments for IO.popen if srcdir is a local path. unless -srcdir command line option is given, srcdir is the default URL. [ruby-core:78036] [Bug #12908]

Revision 56668
Added by nobu (Nobuyoshi Nakada) about 3 years ago

vcs.rb: fix srcdir in VCS::GIT

  • tool/vcs.rb (VCS::GIT.cmd_args): add chdir option to arguments for IO.popen if srcdir is a local path. unless -srcdir command line option is given, srcdir is the default URL. [ruby-core:78036] [Bug #12908]

History

Updated by vo.x (Vit Ondruch) about 3 years ago

  • Assignee set to naruse (Yui NARUSE)

Updated by vo.x (Vit Ondruch) about 3 years ago

  • Subject changed from make-snapshot is broke to make-snapshot is broken
#3

Updated by vo.x (Vit Ondruch) about 3 years ago

  • Related to Misc #12283: Obsolete ChangeLog and commit message in Git-style added

Updated by vo.x (Vit Ondruch) about 3 years ago

It seems that this works:

tool/make-snapshot -packages=xz -srcdir=. tmp

i.e. the -srcdir=. makes a difference ...

#5

Updated by nobu (Nobuyoshi Nakada) about 3 years ago

  • Status changed from Open to Closed

Applied in changeset r56668.


vcs.rb: fix srcdir in VCS::GIT

  • tool/vcs.rb (VCS::GIT.cmd_args): add chdir option to arguments for IO.popen if srcdir is a local path. unless -srcdir command line option is given, srcdir is the default URL. [ruby-core:78036] [Bug #12908]

Updated by vo.x (Vit Ondruch) about 3 years ago

Thx for the fix.

Also available in: Atom PDF