Project

General

Profile

Actions

Bug #12908

closed

make-snapshot is broken

Added by vo.x (Vit Ondruch) over 7 years ago. Updated over 7 years ago.

Status:
Closed
Target version:
-
[ruby-core:78036]

Description

Testing with r56663, the make-snapshot fails with message:

$ tool/make-snapshot -packages=xz tmp
/builddir/ruby/tool/vcs.rb:123:in `realpath': no implicit conversion of URI::HTTP into String (TypeError)
	from /builddir/ruby/tool/vcs.rb:123:in `initialize'
	from tool/make-snapshot:416:in `new'
	from tool/make-snapshot:416:in `<main>'

It does not work since r56638, although the error was different initially.


Related issues 1 (0 open1 closed)

Related to Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-styleClosednaruse (Yui NARUSE)Actions

Updated by vo.x (Vit Ondruch) over 7 years ago

  • Assignee set to naruse (Yui NARUSE)

Updated by vo.x (Vit Ondruch) over 7 years ago

  • Subject changed from make-snapshot is broke to make-snapshot is broken
Actions #3

Updated by vo.x (Vit Ondruch) over 7 years ago

  • Related to Misc #12283: Obsolete ChangeLog and commit message in Git-style added

Updated by vo.x (Vit Ondruch) over 7 years ago

It seems that this works:

tool/make-snapshot -packages=xz -srcdir=. tmp

i.e. the -srcdir=. makes a difference ...

Actions #5

Updated by nobu (Nobuyoshi Nakada) over 7 years ago

  • Status changed from Open to Closed

Applied in changeset r56668.


vcs.rb: fix srcdir in VCS::GIT

  • tool/vcs.rb (VCS::GIT.cmd_args): add chdir option to arguments
    for IO.popen if srcdir is a local path. unless -srcdir command
    line option is given, srcdir is the default URL.
    [ruby-core:78036] [Bug #12908]

Updated by vo.x (Vit Ondruch) over 7 years ago

Thx for the fix.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0