Project

General

Profile

Bug #12547

Remove ONIG_UNICODE_VERSION_... in enc/unicode/case-folding.rb, casefold.h

Added by duerst (Martin Dürst) about 4 years ago. Updated 4 months ago.

Status:
Assigned
Priority:
Normal
Target version:
-
[ruby-core:76252]
Tags:

Description

r55546 defined four macros starting with ONIG_UNICODE_VERSION_...
I haven't found any place where they are used. I don't see any need for them.
If Oniguruma/Onigmo want to introduce them, we can follow, but
we already have RbConfig::CONFIG['UNICODE_VERSION']. If that's not enough, then I suggest we change it so that it's enough in and by itself. As discussed at one of the recent Ruby committers' meetings, there is no plan to let the Unicode Version for Ruby itself and the version for Onigmo to diverge. And Unicode these days is essentially only updated in major versions, so that having four different macros is overkill.

If it turns out that we need these macros in the future, we can always introduce them again, but at the moment, they will just confuse people who are reading the code.


Related issues

Related to CommonRuby - Feature #12546: Remove UnicodeNormalize::UNICODE_VERSIONClosedduerst (Martin Dürst)Actions
#1

Updated by duerst (Martin Dürst) about 4 years ago

  • Related to Feature #12546: Remove UnicodeNormalize::UNICODE_VERSION added
#2

Updated by shyouhei (Shyouhei Urabe) about 3 years ago

  • Status changed from Open to Assigned

Updated by nobu (Nobuyoshi Nakada) 4 months ago

These macros are to ensure that Unicode data files and the header/source files are for the same version.
You won't see them unless something went wrong.

Also available in: Atom PDF