Bug #11754: Visibility scope is kept after lexical scope is closed

• Status: Closed
• Assignee: ko1 (Koichi Sasada)
• Target version: -
• ruby -v: ruby 2.3.0preview1 (2015-11-11 trunk 52539) [x86_64-darwin13]
• Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN

[printercu (Max Melentiev)]

module X
  def self.test_def
   def x; end; 
  end

  private
  def y; end; 
end
X.test_def
X.instance_methods

In 2.2 it returns [:x], in 2.3-preview1 it returns empty array. Is it ok?

[printercu (Max Melentiev)]

Better example

module X
  def self.test_def(name)
    define_method(name) {}
  end

  test_def :x

  private

  test_def :y 

  def pr; end
end

X.test_def :z
X.public_instance_methods
# 2.2.2 => [:x, :y, :z]
# 2.3-preview1 => [:x]

[j15e (Jean-Philippe Doyle)]

• ruby -v set to ruby 2.3.0preview1 (2015-11-11 trunk 52539) [x86_64-darwin13]

To provide some context, this creates issues with two gems I am using that have dynamically defined methods (that now seems to be incorrectly private in 2.3.0preview1) :

• paranoia (really_destroy! method defined in https://github.com/rubysherpas/paranoia/blob/rails4/lib/paranoia.rb#L185-L190)
• money (all methods defined in https://github.com/RubyMoney/money/blob/master/lib/money/money/formatting.rb#L4-L14)

[mame (Yusuke Endoh)]

• Related to Feature #11665: Support nested functions for better code organization added

[ko1 (Koichi Sasada)]

• Assignee set to ko1 (Koichi Sasada)

[ko1 (Koichi Sasada)]

• Status changed from Open to Closed

Applied in changeset r52996.

---

• vm.c (rb_vm_cref_in_context): Module#define_method in non-class
  expression should be public.
  [Bug #11754]

• test/ruby/test_method.rb: add a test.

[nobu (Nobuyoshi Nakada)]

• Related to Bug #13249: Access modifiers don't have an effect inside class methods in Ruby >= 2.3 added