Regexp.quote() and default encoding
I am not sure if this is a bug, or unexpected behaviour (for me).
I will simply report it, I am sure you guys know how and if to
handle this anyway.
I believe it should be documented at least in the official documentation
if it is not a bug.
The situation is that I have several strings with mixed encodings.
Some will have automatically UTF8, some US-ASCII, and yet some
others will have ASCII-8BIT.
I noticed that Regexp.quote() change the encoding of the string
in question in the same project unfortunately, and no way to
change that (as some of that gets set from the outside world
Here is proof for Regexp.quote() changing the encoding, where
x is my test variable - a string:
x = "abc"; x.encoding # => #Encoding:US-ASCII
x.encode!('ASCII-8BIT'); x.encoding # => #Encoding:ASCII-8BIT
Ok, all works fine, it defaulted to US-ASCII but is not
test = Regexp.quote(x); test.encoding # => #Encoding:US-ASCII
Suddenly the new string that is returned has another encoding.
I looked at the documentation:
But there is no mention that this method would return a new
String object with a different encoding.
I would have expected it to not change the encoding of the
argument-string object there.
Perhaps the documentation could mention that it will ignore
the original encoding of the string given?
Updated by jeremyevans (Jeremy Evans) over 1 year ago
- Status changed from Assigned to Closed
Applied in changeset git|32ec6dd5c7cb89979d48100acf8971ac09e0d02e.
Document encoding of string returned by Regexp.quote [ci skip]
Also, remove documentation about returning self, which makes no
sense as self would be the Regexp class. It could be interpreted
as return the argument if no changes were made, but that hasn't
been the behavior at least since 1.8.7 (and probably before).
Fixes [Bug #10239]