Project

General

Profile

Actions

Feature #10129

open

More descriptive error message for failed net/http requests

Added by xshay (Xavier Shay) over 9 years ago. Updated about 6 years ago.

Status:
Assigned
Target version:
-
[ruby-core:64347]

Description

Hello,
I would like to propose the following patch:

Before

2.1.2 :003 > Net::HTTP.get(URI.parse("https://arsrtrtrstsrt.com/arstr"))
SocketError: getaddrinfo: nodename nor servname provided, or not known

After

2.1.2 :003 > Net::HTTP.get(URI.parse("https://arsrtrtrstsrt.com/arstr"))
SocketError: Failed to open TCP connection to arsrtrtrstsrt.com:443 (getaddrinfo: nodename nor servname provided, or not known)

I have an implementation with test at https://github.com/ruby/ruby/pull/700

Thank you for your consideration,
Xavier


Files

net-http-error-message.diff (1.43 KB) net-http-error-message.diff xshay (Xavier Shay), 08/13/2014 10:36 PM

Updated by xshay (Xavier Shay) over 9 years ago

Attaching diff, possibly more useful than github PR.

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

  • Category set to ext
  • Status changed from Open to Assigned
  • Assignee set to akr (Akira Tanaka)
  • Target version set to 2.2.0

Shouldn't Socket methods raise more descriptive messages?

https://github.com/nobu/ruby/compare/socket-error-message

Updated by normalperson (Eric Wong) over 9 years ago

wrote:

Shouldn't Socket methods raise more descriptive messages?

https://github.com/nobu/ruby/compare/socket-error-message

Yes. I think the EAI_SYSTEM case should also include host/port in the
error message, too.

Updated by naruse (Yui NARUSE) over 9 years ago

Nobuyoshi Nakada wrote:

Shouldn't Socket methods raise more descriptive messages?

https://github.com/nobu/ruby/compare/socket-error-message

example domain should use *.invalid
http://tools.ietf.org/html/rfc2606

Actions #5

Updated by naruse (Yui NARUSE) about 6 years ago

  • Target version deleted (2.2.0)
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0