Project

General

Profile

Actions

Bug #9483

closed

Fix typo in OpenURI and Ripper documenation

Added by rondale_sc (Jonathan Jackson) about 10 years ago. Updated about 10 years ago.

Status:
Closed
Assignee:
Target version:
-
[ruby-core:60457]

Description

Fixed grammar error in OpenURI#content_encoding and Ripper#tokenize.

Grouped them together because both were the same typo.


Files

Updated by zzak (zzak _) about 10 years ago

  • Status changed from Open to Assigned
  • Assignee changed from drbrain (Eric Hodel) to zzak (zzak _)

Thanks for the patch, yeah the grammar sounds weird but I think what the author wanted to represent as the actual type of these return values. Hence the capital Array and String, but it makes more sense to just lower case these and move on.

I'll commit a patch soon.

Updated by zzak (zzak _) about 10 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r44878.


  • ext/ripper/lib/ripper/lexer.rb: [DOC] use lower case version of core
    classes when referring to return value, since we aren't directly
    talking about the class. Patch by Jonathan Jackson [Bug #9483]

Updated by usa (Usaku NAKAMURA) about 10 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) about 10 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED to 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: REQUIRED

r44878 and r44879 were backported to ruby_2_0_0 at r44985.

Updated by naruse (Yui NARUSE) about 10 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: REQUIRED to 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONE

r45116

Updated by usa (Usaku NAKAMURA) about 10 years ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE, 2.1: DONE to 1.9.3: DONE, 2.0.0: DONE, 2.1: DONE

backported into ruby_1_9_3 at r45158.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0