Feature #8771
closed
Start does not use proxy configuration form ENV variables
Added by sjltaylor (Sam Taylor) about 11 years ago.
Updated almost 7 years ago.
Description
=begin
- Start a fake proxy in a separate window: (({nc -l 8089}))
- (({export http_proxy=http://localhost:8089}))
- (({irb -r net/http}))
- (({Net::HTTP.start('google.com').get('/')}))
- Note that the above http request was not proxied using the environment configuration
- (({Net::HTTP.new('google.com').get('/')})) exhibits the correct behaviour, the proxied HTTP request can be seen in the nc output
=end
Files
378.patch (3.07 KB)
378.patch |
https://github.com/ruby/ruby/pull/378 |
sjltaylor (Sam Taylor), 08/11/2013 07:09 AM
|
|
- Status changed from Open to Assigned
- Status changed from Assigned to Rejected
Yui NARUSE wrote:
It causes that a client can set http_proxy on CGI environments.
see also akr's comment on https://bugs.ruby-lang.org/issues/6546
Yui can you take closer look at this bug? The patch seems to set the variable correctly to avoid the CGI issue as defined in https://bugs.ruby-lang.org/issues/6546. I believe this bug is valid and that the page makes the behavior between Net::HTTP.start('google.com').get('/') and Net::HTTP.new('google.com').get('/') consistent when dealing with a proxy set in an environment variable.
- Related to Bug #13351: net/http: Net::HTTP.start sets wrong default arg value added
- Tracker changed from Bug to Feature
- Status changed from Rejected to Closed
- ruby -v deleted (
2.1.0dev)
- Backport deleted (
1.9.3: UNKNOWN, 2.0.0: UNKNOWN)
Also available in: Atom
PDF
Like0
Like0Like0Like0Like0Like0Like0