Curses::Window#bkgdset does not handle color correctly
Colors in curses are handled as high bits on a character. Logically ORing a character with a color pair should allow bkgdset to configure a colored background. This can be seen in the source for the Python curses module. The Python function takes one or two arguments (color + character). If there are two arguments they are ORed together and passed to curses as such. Back in ruby land, with one argument it should be possible to specify a background color for the whole screen thusly:
Define a color pair¶
Curses.init_pair(1, Curses::COLOR_GREEN, Curses::COLOR_BLUE)
Set the screen background to blue¶
Curses.bkgdset(' '.ord | Curses.color_pair(1))
Curses.init_pair(1, Curses::COLOR_YELLOW, Curses::COLOR_BLUE)
Curses.bkgdset('='.ord | Curses.color_pair(1))
Should fill the screen with equals signs (yellow on blue background), and prompt the user to press any key to continue. With Ruby 1.9.3 this doesn't work. The curses module assumes curses characters are one byte (typeof(chtype) == char). Yet GNU ncurses defines the chtype data type as an unsigned integer (OSX 10.8) or an unsigned long (FreeBSD 9.1, RedHat 7.3). The curses module defines a macro "NUM2CH" to convert from ruby objects to chtype objects. At present NUM2CH is defined as NUM2CHR. Instead NUM2CH should be defined as NUM2INT to allow for values > 255 (ex: character + color).
Updated by shugo (Shugo Maeda) almost 9 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r43074.
Alex, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
ext/curses/extconf.rb: check the size of chtype.
ext/curses/curses.c (NUM2CH, CH2NUM): use proper macros for
the size of chtype.