Project

General

Profile

Actions

Bug #861

closed

Rake::MultiTask#invoke_prerequisites should be private

Added by okkez (okkez _) over 15 years ago. Updated almost 13 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
Backport:
[ruby-dev:37399]

Description

=begin
Rake::Task#invoke_prerequisites が private なので
Rake::MultiTask#invoke_prerequisites も private な方がいいと思いました。

Index: rake.rb

--- rake.rb (revision 20655)
+++ rake.rb (working copy)
@@ -802,6 +802,7 @@
# parallel using Ruby threads.
#
class MultiTask < Task

  • private
    def invoke_prerequisites(args, invocation_chain)
    threads = @prerequisites.collect { |p|
    Thread.new(p) { |r| application[r].invoke_with_call_chain(args, invocation_chain) }
    =end
Actions #1

Updated by ko1 (Koichi Sasada) over 15 years ago

=begin
 ささだです.

 作者は Jim Weirich なので,ちょっと英語にして ruby-core に振った方がよ
いかと思いますが,いかがでしょうか.

okkez _ wrote::

Bug #861: Rake::MultiTask#invoke_prerequisites should be private
http://redmine.ruby-lang.org/issues/show/861

起票者: okkez _
ステータス: Open, 優先度: Normal
カテゴリ: lib

Rake::Task#invoke_prerequisites が private なので
Rake::MultiTask#invoke_prerequisites も private な方がいいと思いました。

Index: rake.rb

--- rake.rb (revision 20655)
+++ rake.rb (working copy)
@@ -802,6 +802,7 @@

parallel using Ruby threads.

class MultiTask < Task

  • private
    def invoke_prerequisites(args, invocation_chain)
    threads = @prerequisites.collect { |p|
    Thread.new(p) { |r| application[r].invoke_with_call_chain(args, invocation_chain) }

http://redmine.ruby-lang.org

--
// SASADA Koichi at atdot dot net

=end

Actions #2

Updated by matz (Yukihiro Matsumoto) over 15 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
Applied in changeset r20908.
=end

Actions

Also available in: Atom PDF

Like0
Like0Like0