Bug #8315: mkmf does not include include paths from pkg_config anymore

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -
• ruby -v: trunk
• Backport: 2.0.0: DONE, 2.1: DONE

[Hanmac (Hans Mackowiak)]

#6504 does that, for cpp files $CFLAGS is not used anymore, so the problems are the include paths:

• there is no $CXXFLAGS global variable defined
• pkg_config does not add the includes paths to the correct *FLAGS

so my gems are currently broken for ruby trunk and if i fix that it may be broken for the older ruby

[Hanmac (Hans Mackowiak)]

ups i assiged it to the wrong nobu, can someone change that?

[nobu (Nobuyoshi Nakada)]

• Assignee changed from iwamatsu (Nobuhiro Iwamatsu) to nobu (Nobuyoshi Nakada)

[Hanmac (Hans Mackowiak)]

have somone time to fix that?
currently it still does needed to fix it by myself to get the gems working

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

Applied in changeset r47457.

---

mkmf.rb: --cflags to $CXXFLAGS

• lib/mkmf.rb (MakeMakefile#pkg_config): append --cflags to also
  $CXXFLAGS, as they are often used by C++ compiler.
  [ruby-core:54532] [Bug #8315]

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 2.0.0: REQUIRED, 2.1: REQUIRED

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE

Backported into ruby_2_1 branch at r47587.

[nagachika (Tomoyuki Chikanaga)]

• Related to Backport #6504: mkmf.rb should not use CFLAGS when compiling C++ code added

[nagachika (Tomoyuki Chikanaga)]

Sorry, r47587 breaks build of digests/*.

I overlooked r44459 and r44460 because they seems a new feature (and there's no ticket for these commits).
But I think r44459 is rather a bug fix for degrade introduced by r39994.
I additionally backported r44459 and r44470 to check if they fix build error on RubyCI.

usa san, how do you think? ruby_2_0_0 includes r39994 too.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.0.0: REQUIRED, 2.1: DONE to 2.0.0: DONE, 2.1: DONE

backported into ruby_2_0_0 at r47609.

nagachika san:
I think that r44459 (and r44470) is a bug fix (lack of specification or implementation).
Thank you for information.