Bug #7667: Should Refinements be enabled by default?

• Status: Closed
• Assignee: shugo (Shugo Maeda)
• Target version: -
• ruby -v: ruby 2.0.0dev (2013-01-07 trunk 38719) [i686-linux]

[shugo (Shugo Maeda)]

Currently, `require "refinement"' is needed to use Refinements, but I've heard from Matz that he wants Refinements to be enabled by default.
Is it right, Matz?

If so, I'm worried that other implementors might not want to enable Refinements by default, because it's an experimental feature.

[matz (Yukihiro Matsumoto)]

• Assignee changed from matz (Yukihiro Matsumoto) to shugo (Shugo Maeda)

Correct. I think we don't have to worry about other implementations if it's marked as EXPERIMENTAL in the NEWS file.

Matz.

[shugo (Shugo Maeda)]

matz (Yukihiro Matsumoto) wrote:

Correct. I think we don't have to worry about other implementations if it's marked as EXPERIMENTAL in the NEWS file.

I think a warning should be shown when Module#refine or main.using is called at the first time.

[shugo (Shugo Maeda)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r38729.
Shugo, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• eval.c (Init_eval): enable Refinements by default.
  [ruby-core:51286] [Bug #7667]

• eval.c (rb_mod_refine, top_using): show a warning when
  Module#refine or main.using is called at the first time.

• ext/refinement/*: removed the extension library "refinement".

• test/ruby/test_refinement.rb: fix for the above changes.