Bug #7528: CSV.== fails to check object type

• Status: Closed
• Assignee: JEG2 (James Gray)
• Target version: 2.0.0
• ruby -v: ruby 1.9.3p327 (2012-11-10 revision 37606) [x86_64-linux]

[SteveW (Stephen Wattam)]

CSV::Row's equality method presumes it is comparing another CSV::Row. It fails when the object to be compared doesn't support the 'row' method:

/usr/lib/ruby/1.9.1/csv.rb:478:in ==': undefined method row' for nil:NilClass (NoMethodError)
from test.rb:7:in `'

[SteveW (Stephen Wattam)]

This seems to fix it:

478c478,479
<       @row == other.row
---
>       return @row == other.row if other.class == CSV::Row
>       @row == other

It would probably be better to perform an is_a? check rather than
checking the class of the other object.

[SteveW (Stephen Wattam)]

• File csv.rb.patch csv.rb.patch added

I concur. Patch attached for easy application.

It's probably worth noting that the current, unpatched, behaviour seems to break foreach too.

[drbrain (Eric Hodel)]

• Category set to lib
• Status changed from Open to Assigned
• Assignee set to JEG2 (James Gray)
• Target version set to 2.0.0

[JEG2 (James Gray)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r38265.
Stephen, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• lib/csv.rb: A fix for row comparison by Stephen Wattam. [Bug #7528]

[zzak (zzak _)]

James, I think your editor may have committed a bunch of whitespace changes