Bug #7439: Please revert r32841

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -
• ruby -v: ruby 2.0.0dev (2012-11-07 trunk 37807) [x86_64-linux]

[vo.x (Vit Ondruch)]

I cannot find any reference why r32841 was committed and what is the real issue it solves, but since R1.8 cannot be used as a baseruby anymore (./ext/extmk.rb:228:in extmake': undefined method prepend' for #String:0x7fed568d8e20 (NoMethodError)) nor is Ruby 1.8 supported, I propose to remove this workaround and stay with standard RubyGems functionality.

[luislavena (Luis Lavena)]

• Category set to build
• Status changed from Open to Assigned
• Assignee set to nobu (Nobuyoshi Nakada)

This was applied due a bunch of issues cross-compiling Ruby 1.9.x using Ruby 1.8.7 as baseline.

I'm not sure if this is still the case for BASERUBY being 1.8 and other changes that might not allow 1.8 to cross-compile 1.9.x

I'm assigning this to Nobu for final decision.

[vo.x (Vit Ondruch)]

=begin
This is error I get when using 1.8 for cross-compilation:
./ext/extmk.rb:228:in extmake': undefined method prepend' for #String:0x7fed568d8e20 (NoMethodError)
from ./ext/extmk.rb:504
from ./ext/extmk.rb:500:in `each'
from ./ext/extmk.rb:500

and String#prepend is available since Ruby 1.9.3 AFAIK, therefore Ruby 1.8 cannot be (currently) used for cross-compilation.

But no regret about that, I'd love to see Ruby 1.8 dead and my patch applied ;)
=end

[nobu (Nobuyoshi Nakada)]

That line is not in r32841.

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r37870.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

extmk.rb: git rid of post-1.8 features

• ext/extmk.rb (extmake): git rid of post-1.8 features for cross
  compilation. [ruby-core:50160] [Bug #7439]

[vo.x (Vit Ondruch)]

• Status changed from Closed to Assigned

Well, may be it was incomprehensible, but I really wanted you to accept my patch, not fix the Ruby 1.8 support as a BASERUBY.

And the reasoning was: "Since Ruby 1.8 cannot be used as a BASERUBY due to (or at least) the line I am pointing out, you can safely accept my patch (i.e. revert r32841), since it simplifies current codebase and makes it more readable and intuitive".

So what is the status? Should Ruby 1.8 be still be usable as a BASERUBY or not? Since Ruby 1.8 is unsupported since May 2012, I would say that the pach/revert should be acceptable. On the other hand you committed r37870 and it would indicate that the opposite is true.

Could you please clarify?

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed

This issue was solved with changeset r37878.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

extconf.rb: git rid of post-1.8 feature

• ext/digest/*/extconf.rb, ext/openssl/extconf.rb: get git rid of
  post-1.8 feature require_relative for cross compilation.
  [ruby-core:50160] [Bug #7439]