Backport #7255: Ripper inside class_eval ommits :string_content between new line and :string_embexpr

• Status: Closed
• Assignee: usa (Usaku NAKAMURA)

[brueckenschlaeger23 (Micha J)]

See the following Code parsed by Ripper using

content = 'class_eval <<-RUBY, __FILE__, __LINE__+1        
    
    def #{parent}contents(*args)
      ""
    end
RUBY
'

Ripper::SexpBuilder.new(content).parse

The resulting sexp ommits truncates the first string_add to " \n" instead of " \n def "

        - - :string_literal
          - - :string_add
            - - :string_add
              - - :string_add
                - - :string_content
                - - :@tstring_content
                  - "        \n"
                  - - 2
                    - 0

If you remove the empty line, it works fine and the " def " is part of the string. As well it works without any embed #{}.

[brueckenschlaeger23 (Micha J)]

I noticed, that this bug reaches a bit wider:

'class_eval <<-RUBY, __FILE__, __LINE__+1        
    
    def #{parent}_contents(*args)
      test = ""
      test ||= "#{parent}" 
    end
RUBY
'

' test ||= "' also is omitted by ripper. This is the string between the "\n" of [:@tstring_content, "_contents(*args)\n test = ""\n", [3, 21]]] and the next embed.

[brueckenschlaeger23 (Micha J)]

Another update: It's not connected to class_eval but to the <<-RUBY and <<RUBY multiline String versions. This is my only use case for this format so I didn't notice.

[brueckenschlaeger23 (Micha J)]

I did some further digging regarding the parser/scanner events.

Basically the cause for the error can be seen here (parsing the example from the description).

[:@ident, "class_eval", [1, 0]]
[:@sp, " ", [1, 10]]
[:@heredoc_beg, "<<-RUBY", [1, 11]]
[:string_content]
[:@tstring_content, "        \n", [2, 0]]
[:string_add, [:string_content], [:@tstring_content, "        \n", [2, 0]]]
[:@embexpr_beg, "        def \#{", [3, 0]]   <------- this line
...

The scanner-event :@embexpr_beg contains the missing text which then will be discarded to create the string_embexp from the sexp.

[zzak (zzak _)]

• Category set to ext
• Assignee set to nobu (Nobuyoshi Nakada)

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r38235.
Micha, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

parse.y: flush string content

• parse.y (parser_here_document): flush string content between new
  line and :string_embexpr. [ruby-core:48703] [Bug #7255]

[nobu (Nobuyoshi Nakada)]

• Tracker changed from Bug to Backport
• Project changed from Ruby to 13
• Category deleted (ext)
• Status changed from Closed to Assigned
• Assignee changed from nobu (Nobuyoshi Nakada) to usa (Usaku NAKAMURA)

[usa (Usaku NAKAMURA)]

• Status changed from Assigned to Closed

This issue was solved with changeset r38319.
Micha, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 38235: [Backport #7255]

* parse.y (parser_here_document): flush string content between new
  line and :string_embexpr.  [ruby-core:48703] [Bug #7255]