Project

General

Profile

Feature #6236

WEBrick::HTTPServer swallows Exception

Added by regularfry (Alex Young) over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:43996]

Description

At the moment when using WEBrick you've always got to remember to define a signal handler to be able to kill the server when you're done with it. This is annoying and makes it more painful to use than it should be, because if you realise you've forgotten to define a trap("INT") handler after you've started the server, all you can do is kill -9 the process. This also catches out people learning the library more than it should. It shouldn't be the web server's job to take over process management, but that's what it ends up doing.

The reason this happens is because webrick/server.rb uses rescue Exception around its accept loop. This is more broad than it should be. The attached patch replaces this with a rescue StandardError, and causes other Exception subclasses to be logged and re-raised. This makes WEBrick::HTTPServer somewhat more friendly to use at the command-line.

If you Ctrl-c out of a server.start loop with this patch applied, you can't restart the server because it leaves internal state lying around, but I think it's still an improvement over the current situation.


Files

standarderror.patch (626 Bytes) standarderror.patch regularfry (Alex Young), 03/31/2012 06:18 PM
webrick.signal_exception.patch (1.26 KB) webrick.signal_exception.patch Exit WEBrick on any SignalException, not just SIGINT drbrain (Eric Hodel), 04/14/2012 07:50 AM

Also available in: Atom PDF