Project

General

Profile

Backport #5465

Ruby 1.9.3 fails to compile with tcl/tk on s390x

Added by Anonymous about 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:40243]

Description

When compiling Ruby 1.9.3 on s390x without specifying --libdir for configure, tcl/tk extension fails to build: Fail to find [tclConfig.sh, tkConfig.sh].
This is caused by erroneous function maybe_64bit? in ext/tk/extconf.rb, which doesn't recognize s390x as 64 bit architecture.

Proposed fix is in attached file.


Files

ruby-1.9.3-fix-s390x-build.patch (416 Bytes) ruby-1.9.3-fix-s390x-build.patch Anonymous, 10/20/2011 04:45 PM

Associated revisions

Revision c58dc636
Added by nagai (Hidetoshi Nagai) over 6 years ago

  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@41347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 41347
Added by nagai (Hidetoshi Nagai) over 6 years ago

  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Revision 41347
Added by nagai (Hidetoshi Nagai) over 6 years ago

  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Revision 41347
Added by nagai (Hidetoshi Nagai) over 6 years ago

  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Revision 41347
Added by nagai (Hidetoshi Nagai) over 6 years ago

  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Revision 41347
Added by nagai (Hidetoshi Nagai) over 6 years ago

  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Revision 41347
Added by nagai (Hidetoshi Nagai) over 6 years ago

  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Revision e4fd9de9
Added by nagachika (Tomoyuki Chikanaga) over 6 years ago

merge revision(s) 41347: [Backport #5048] [Backport #5465] [Backport #8319]

    * ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
    * ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
    * ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@41362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 8149f70e
Added by usa (Usaku NAKAMURA) over 6 years ago

merge revision(s) 41347: [Backport #8319]

    * ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
    * ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
    * ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@41651 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 41651
Added by usa (Usaku NAKAMURA) over 6 years ago

merge revision(s) 41347: [Backport #8319]

* ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
* ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
* ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

History

Updated by Anonymous almost 8 years ago

Ping, any progress? I think its quite clear...

Updated by ko1 (Koichi Sasada) over 7 years ago

  • Category set to ext
  • Assignee set to nagai (Hidetoshi Nagai)
#3

Updated by shyouhei (Shyouhei Urabe) over 7 years ago

  • Status changed from Open to Assigned

Updated by vo.x (Vit Ondruch) almost 7 years ago

Can this be applied, please? We are using this patch in Fedora and RHEL to fix build issues on s390x. Thank you.

#5

Updated by nagai (Hidetoshi Nagai) over 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41347.
Bohuslav, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]
#6

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport200
  • Category deleted (ext)
  • Status changed from Closed to Assigned
  • Assignee changed from nagai (Hidetoshi Nagai) to nagachika (Tomoyuki Chikanaga)
#7

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r41362.
Bohuslav, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41347: [Backport #5048] [Backport #5465] [Backport #8319]

* ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
* ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
* ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]
#8

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Project changed from Backport200 to Backport193
  • Status changed from Closed to Assigned
  • Assignee changed from nagachika (Tomoyuki Chikanaga) to usa (Usaku NAKAMURA)

related tickets: #5048 #8319

#9

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r41651.
Bohuslav, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41347: [Backport #8319]

* ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
* ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
* ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Also available in: Atom PDF