Backport #5465

Ruby 1.9.3 fails to compile with tcl/tk on s390x

Added by Anonymous almost 4 years ago. Updated about 2 years ago.

[ruby-core:40243]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

When compiling Ruby 1.9.3 on s390x without specifying --libdir for configure, tcl/tk extension fails to build: Fail to find [tclConfig.sh, tkConfig.sh].
This is caused by erroneous function maybe_64bit? in ext/tk/extconf.rb, which doesn't recognize s390x as 64 bit architecture.

Proposed fix is in attached file.

ruby-1.9.3-fix-s390x-build.patch Magnifier (416 Bytes) Anonymous, 10/20/2011 04:45 PM

Associated revisions

Revision 41347
Added by Hidetoshi Nagai about 2 years ago

  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Revision 41651
Added by Usaku NAKAMURA about 2 years ago

merge revision(s) 41347: [Backport #8319]

* ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
* ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
* ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

History

#1 Updated by Anonymous over 3 years ago

Ping, any progress? I think its quite clear...

#2 Updated by Koichi Sasada over 3 years ago

  • Assignee set to Hidetoshi Nagai
  • Category set to ext

#3 Updated by Shyouhei Urabe over 3 years ago

  • Status changed from Open to Assigned

#4 Updated by Vit Ondruch over 2 years ago

Can this be applied, please? We are using this patch in Fedora and RHEL to fix build issues on s390x. Thank you.

#5 Updated by Hidetoshi Nagai about 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

This issue was solved with changeset r41347.
Bohuslav, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
  • ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
  • ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

#6 Updated by Tomoyuki Chikanaga about 2 years ago

  • Project changed from Ruby trunk to Backport200
  • Category deleted (ext)
  • Status changed from Closed to Assigned
  • Assignee changed from Hidetoshi Nagai to Tomoyuki Chikanaga
  • Tracker changed from Bug to Backport

#7 Updated by Tomoyuki Chikanaga about 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r41362.
Bohuslav, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41347: [Backport #5048] [Backport #5465] [Backport #8319]

* ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
* ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
* ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

#8 Updated by Tomoyuki Chikanaga about 2 years ago

  • Project changed from Backport200 to Backport193
  • Status changed from Closed to Assigned
  • Assignee changed from Tomoyuki Chikanaga to Usaku NAKAMURA

related tickets: #5048 #8319

#9 Updated by Usaku NAKAMURA about 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r41651.
Bohuslav, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41347: [Backport #8319]

* ext/tk/extconf.rb: support s390x (Thanks to bkabrda) [ruby-trunk - Bug #5465]
* ext/tk/extconf.rb: apply [Backport87 - Backport #5048]
* ext/tk/lib/tk/canvas.rb, ext/tk/sample/demos-{en,jp}/{tree.rb,widget}: fix bug (Thanks to zzak) [ruby-trunk - Bug #8319]

Also available in: Atom PDF