Feature #5373: SMTP - new method

• Status: Closed
• Assignee: drbrain (Eric Hodel)
• Target version: 2.6

[art.lussos (art lussos)]

I would like to add the following method to smtp.rb command dispatcher section.

The reset command tells the mail server that the current mail transaction should be aborted.

def reset
getok('RSET')
end

[mame (Yusuke Endoh)]

• Status changed from Open to Assigned
• Assignee set to aamine (Minero Aoki)

[mame (Yusuke Endoh)]

• Status changed from Assigned to Feedback

Could you please create a test?

--
Yusuke Endoh [e-mail]

[drbrain (Eric Hodel)]

• File net.smtp.rb.rset.patch net.smtp.rb.rset.patch added

Here is a patch with a test, may I commit?

There aren't many net/smtp tests so perhaps there is a better way than FakeSocket.

[drbrain (Eric Hodel)]

• Status changed from Feedback to Assigned

[drbrain (Eric Hodel)]

• Category set to lib
• Target version set to 2.0.0

May I apply this?

[shugo (Shugo Maeda)]

• Assignee changed from aamine (Minero Aoki) to mame (Yusuke Endoh)

drbrain (Eric Hodel) wrote:

May I apply this?

Sasada-san told me that Aoki-san is neutral about this issue, and asked my take as a maintainer of Net::IMAP.

I think it's nice Net::SMTP to have a new method for the RSET command, but what do you think of it, Endo-san?

If permission is granted by Endo-san, there's one consideration about the method name.
The originally proposed method name is reset', but the method name in the Eric's patch is rset'.
I think `rset' is better, because other methods of Net::STMP have the same names as the SMTP command names.

[drbrain (Eric Hodel)]

I chose rset because it matches the other methods that follow the SMTP protocol in Net::SMTP like helo, ehlo, rcptto, mailfrom

[mame (Yusuke Endoh)]

• Assignee changed from mame (Yusuke Endoh) to matz (Yukihiro Matsumoto)

I can't say anything but "no" because the deadline has passed.
So, don't ask me.

--
Yusuke Endoh [e-mail]

[mame (Yusuke Endoh)]

• Target version changed from 2.0.0 to 2.6

[drbrain (Eric Hodel)]

• Assignee changed from matz (Yukihiro Matsumoto) to drbrain (Eric Hodel)

Since Aoki-san was listed as neutral last I asked, I will apply this sometime next week.

[drbrain (Eric Hodel)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r39729.
art , thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• lib/net/smtp.rb: Added Net::SMTP#rset method to implement the SMTP
  RSET command. [ruby-trunk - Feature #5373]
• NEWS: ditto.
• test/net/smtp/test_smtp.rb: Test for the above.