Project

General

Profile

Actions

Bug #5292

closed

Access to GC::Profiler Records

Added by cfis (Charlie Savage) over 13 years ago. Updated over 13 years ago.

Status:
Closed
Assignee:
-
Target version:
ruby -v:
ruby 1.9.3dev (2011-09-02 revision 33163) [i386-mswin32_100]
Backport:
[ruby-core:39329]

Description

Could the method gc_profile_record_get be made part of the GC::Profiler class? It returns an array of hashes of various interesting GC measurements.

I'd like ruby-prof to hook into it. Unfortunately, only textual output is currently supported via gc_profile_result. And parsing that output would be a pain.

To do this:

  • 1 line patch to gcc.c:

rb_define_singleton_method(rb_mProfiler, "records", gc_profile_record_get, 0);

  • Is is a safe change since the result is a newly created array of hashes each time.

  • Its useful for performance analysis tools (like ruby-prof)

Would be great to have this in 1.9.3 if at all possible.

Thanks - Charlie


Related issues 1 (0 open1 closed)

Is duplicate of Ruby master - Bug #4991: Add a method to retrieve raw data from GC::ProfilerClosedko1 (Koichi Sasada)07/08/2011Actions

Updated by cfis (Charlie Savage) over 13 years ago

Sorry - I missed that there was already a request for this two months ago - see #4991. It includes the 1 line patch as well as documentation.

Could it be applied?

Actions #2

Updated by authorNari (Narihiro Nakamura) over 13 years ago

  • Status changed from Open to Closed

This issue was solved with changeset r33224.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • gc.c (Init_GC): defined GC::Profiler.raw_data. based on the
    patch by Eric Hodel. [ruby-core:37857] [Bug #4991]

Updated by cfis (Charlie Savage) over 13 years ago

Thank you.

Can this be part of 1.9.3 or is it too late?

Charlie

Updated by authorNari (Narihiro Nakamura) over 13 years ago

Charlie Savage wrote:

Thank you.

Can this be part of 1.9.3 or is it too late?

Charlie

Sorry, it's too late, because 1.9.3 branch already in feature freeze.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0