Bug #4989
closed
Document Socket constants
Added by drbrain (Eric Hodel) over 13 years ago. Updated over 13 years ago.
Description
The attached patch documents most of the Socket constants by adding a third field to ext/socket/mkconstants.rb containing the documentation.
I'm not sure if all the documentation I wrote is correct since finding the appropriate information across all the supported platforms was difficult.
May I commit it?
Files
| socket.constants.patch (21.1 KB) socket.constants.patch | drbrain (Eric Hodel), 07/08/2011 05:43 AM |
Updated by kosaki (Motohiro KOSAKI) over 13 years ago
- Priority changed from Normal to 3
Updated by Anonymous over 13 years ago
Why change all the statuses to low here? I don't see the validity of
your change, especially as this one comes with a patch: surely that
should be higher, to ensure the patch can be cleanly applied?
On Fri, Jul 8, 2011 at 04:50, Motohiro KOSAKI kosaki.motohiro@gmail.com wrote:
Issue #4989 has been updated by Motohiro KOSAKI.
Priority changed from Normal to Low
Bug #4989: Document Socket constants
http://redmine.ruby-lang.org/issues/4989Author: Eric Hodel
Status: Open
Priority: Low
Assignee:
Category:
Target version: 1.9.3
ruby -v: ruby 1.9.3dev (2011-07-07 trunk 32431) [x86_64-darwin10.8.0]The attached patch documents most of the Socket constants by adding a third field to ext/socket/mkconstants.rb containing the documentation.
I'm not sure if all the documentation I wrote is correct since finding the appropriate information across all the supported platforms was difficult.
May I commit it?
Updated by kosaki (Motohiro KOSAKI) over 13 years ago
- ruby -v changed from ruby 1.9.3dev (2011-07-07 trunk 32431) [x86_64-darwin10.8.0] to -
Hi
Why change all the statuses to low here? I don't see the validity of
your change, especially as this one comes with a patch: surely that
should be higher, to ensure the patch can be cleanly applied?
'low' mean this ticket has no impact to 193 release schedule. I didn't see
the patch. I think Eric and akr-san will decide to commit it or not.
Thanks.
Updated by Anonymous over 13 years ago
On Fri, Jul 8, 2011 at 08:25, KOSAKI Motohiro kosaki.motohiro@gmail.com wrote:
Hi
Why change all the statuses to low here? I don't see the validity of
your change, especially as this one comes with a patch: surely that
should be higher, to ensure the patch can be cleanly applied?'low' mean this ticket has no impact to 193 release schedule. I didn't see
the patch. I think Eric and akr-san will decide to commit it or not.
OK, thanks for the clarification. So Low status bugs can get fixed
prior to 1.9.3 release?
Updated by kosaki (Motohiro KOSAKI) over 13 years ago
2011/7/9 James Cox james@imaj.es:
On Fri, Jul 8, 2011 at 08:25, KOSAKI Motohiro kosaki.motohiro@gmail.com wrote:
Hi
Why change all the statuses to low here? I don't see the validity of
your change, especially as this one comes with a patch: surely that
should be higher, to ensure the patch can be cleanly applied?'low' mean this ticket has no impact to 193 release schedule. I didn't see
the patch. I think Eric and akr-san will decide to commit it or not.OK, thanks for the clarification. So Low status bugs can get fixed
prior to 1.9.3 release?
Yes. But, for clarification, this ticket need that Eric and akr-san
agree the change, I think.
Updated by drbrain (Eric Hodel) over 13 years ago
On Jul 8, 2011, at 10:04 AM, KOSAKI Motohiro wrote:
2011/7/9 James Cox james@imaj.es:
On Fri, Jul 8, 2011 at 08:25, KOSAKI Motohiro kosaki.motohiro@gmail.com wrote:
Hi
Why change all the statuses to low here? I don't see the validity of
your change, especially as this one comes with a patch: surely that
should be higher, to ensure the patch can be cleanly applied?'low' mean this ticket has no impact to 193 release schedule. I didn't see
the patch. I think Eric and akr-san will decide to commit it or not.OK, thanks for the clarification. So Low status bugs can get fixed
prior to 1.9.3 release?Yes. But, for clarification, this ticket need that Eric and akr-san
agree the change, I think.
Yes.
I am less concerned about the structure of the patch and more concerned about the content of the patch. If you are experienced in the various socket constants I would appreciate if anyone could review the documentation I have added.
Updated by naruse (Yui NARUSE) over 13 years ago
- Status changed from Open to Assigned
- Assignee set to akr (Akira Tanaka)
Updated by akr (Akira Tanaka) over 13 years ago
2011/7/8 Eric Hodel drbrain@segment7.net:
The attached patch documents most of the Socket constants by adding a third field to ext/socket/mkconstants.rb containing the documentation.
I'm not sure if all the documentation I wrote is correct since finding the appropriate information across all the supported platforms was difficult.
May I commit it?
Sorry for late response.
I don't like the constants table format separated by single TAB
because TAB is not distinguishable from SPACE in visual.
I'll commit the patch and change it.¶
Tanaka Akira
Updated by akr (Akira Tanaka) over 13 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r32735.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
- ext/socket/mkconstants.rb: add documents for constants.
patch by Eric Hodel. [ruby-core:37853] [Bug #4989]