Feature #4924: mkmf have_header fails with C++ headers

• Status: Assigned
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -

[adgar (Michael Edgar)]

=begin
When a user calls (({have_header('some_cpp_header.h')})), and then header includes a line such as(({ #include })), mkmf will fail.

An example run follows:

• extconf.rb

  require 'mkmf'
  have_library('stdc++')
  have_header('BasicBlock.h')
  create_makefile('laser/BasicBlock')

• mkmf.log
  have_header: checking for BasicBlock.h... -------------------- no

  "gcc -E -I/Users/michaeledgar/.rvm/rubies/ruby-1.9.2-head/include/ruby-1.9.1/x86_64-darwin10.7.0 -I/Users/michaeledgar/.rvm/rubies/ruby-1.9.2-head/include/ruby-1.9.1/ruby/backward -I/Users/michaeledgar/.rvm/rubies/ruby-1.9.2-head/include/ruby-1.9.1 -I. -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -O3 -ggdb -Wextra -Wno-unused-parameter -Wno-parentheses -Wpointer-arith -Wwrite-strings -Wno-missing-field-initializers -Wshorten-64-to-32 -Wno-long-long -fno-common -pipe conftest.c -o conftest.i"
  In file included from conftest.c:3:
  ./BasicBlock.h:4:18: error: vector: No such file or directory
  ./BasicBlock.h:5:21: error: exception: No such file or directory
  ./BasicBlock.h:6:21: error: stdexcept: No such file or directory
  checked program was:
  /* begin /
  1: #include "ruby.h"
  2:
  3: #include <BasicBlock.h>
  / end */

The issue here is that the temporary file created to perform the header test is ((%conftest.c%)), not ((%conftest.cc%)) or ((%conftest.cpp%)). Changing the
name of the file and re-running gcc gives success.

In ((%mkmf.rb%)), have_header executes cpp_command, which creates the shell command to run. However, cpp_command uses the constant (({CONFTEST_C = "conftest.c"})). It should use a new constant, (({CONFTEST_CPP = "conftest.cc"})).

I've attached a patch that does this as expected. Tests pass; I'm unsure precisely how to construct
a test case that would be appropriate for the Ruby trunk. There are very few guiding examples in the
existing test suite.

[nobu (Nobuyoshi Nakada)]

• Tracker changed from Bug to Feature
• Priority changed from Normal to 3

[mame (Yusuke Endoh)]

• Status changed from Open to Assigned
• Assignee set to nobu (Nobuyoshi Nakada)

[mame (Yusuke Endoh)]

• Target version set to 2.6

[mame (Yusuke Endoh)]

• Related to Feature #3333: mkmf (have|find)_cxx_header added

[mame (Yusuke Endoh)]

• Related to deleted (Feature #3333: mkmf (have|find)_cxx_header)

[mame (Yusuke Endoh)]

• Is duplicate of Feature #3333: mkmf (have|find)_cxx_header added

[naruse (Yui NARUSE)]

• Target version deleted (2.6)