Project

General

Profile

Actions

Feature #4924

open

mkmf have_header fails with C++ headers

Added by adgar (Michael Edgar) almost 13 years ago. Updated over 6 years ago.

Status:
Assigned
Target version:
-
[ruby-core:37337]

Description

=begin
When a user calls (({have_header('some_cpp_header.h')})), and then header includes a line such as(({ #include })), mkmf will fail.

An example run follows:

  • extconf.rb

    require 'mkmf'
    have_library('stdc++')
    have_header('BasicBlock.h')
    create_makefile('laser/BasicBlock')

  • mkmf.log
    have_header: checking for BasicBlock.h... -------------------- no

    "gcc -E -I/Users/michaeledgar/.rvm/rubies/ruby-1.9.2-head/include/ruby-1.9.1/x86_64-darwin10.7.0 -I/Users/michaeledgar/.rvm/rubies/ruby-1.9.2-head/include/ruby-1.9.1/ruby/backward -I/Users/michaeledgar/.rvm/rubies/ruby-1.9.2-head/include/ruby-1.9.1 -I. -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -O3 -ggdb -Wextra -Wno-unused-parameter -Wno-parentheses -Wpointer-arith -Wwrite-strings -Wno-missing-field-initializers -Wshorten-64-to-32 -Wno-long-long -fno-common -pipe conftest.c -o conftest.i"
    In file included from conftest.c:3:
    ./BasicBlock.h:4:18: error: vector: No such file or directory
    ./BasicBlock.h:5:21: error: exception: No such file or directory
    ./BasicBlock.h:6:21: error: stdexcept: No such file or directory
    checked program was:
    /* begin /
    1: #include "ruby.h"
    2:
    3: #include <BasicBlock.h>
    /
    end */

The issue here is that the temporary file created to perform the header test is ((%conftest.c%)), not ((%conftest.cc%)) or ((%conftest.cpp%)). Changing the
name of the file and re-running gcc gives success.

In ((%mkmf.rb%)), have_header executes cpp_command, which creates the shell command to run. However, cpp_command uses the constant (({CONFTEST_C = "conftest.c"})). It should use a new constant, (({CONFTEST_CPP = "conftest.cc"})).

I've attached a patch that does this as expected. Tests pass; I'm unsure precisely how to construct
a test case that would be appropriate for the Ruby trunk. There are very few guiding examples in the
existing test suite.


Related issues 2 (0 open2 closed)

Related to Ruby master - Feature #3330: mkmf (find|have)_cxx_headerRejectednobu (Nobuyoshi Nakada)Actions
Is duplicate of Ruby master - Feature #3333: mkmf (have|find)_cxx_headerRejectednobu (Nobuyoshi Nakada)Actions
Actions #1

Updated by nobu (Nobuyoshi Nakada) almost 13 years ago

  • Tracker changed from Bug to Feature
  • Priority changed from Normal to 3

Updated by mame (Yusuke Endoh) about 12 years ago

  • Status changed from Open to Assigned
  • Assignee set to nobu (Nobuyoshi Nakada)

Updated by mame (Yusuke Endoh) over 11 years ago

  • Target version set to 2.6
Actions #4

Updated by mame (Yusuke Endoh) over 6 years ago

Actions #5

Updated by mame (Yusuke Endoh) over 6 years ago

  • Related to deleted (Feature #3333: mkmf (have|find)_cxx_header)
Actions #6

Updated by mame (Yusuke Endoh) over 6 years ago

  • Is duplicate of Feature #3333: mkmf (have|find)_cxx_header added
Actions #7

Updated by naruse (Yui NARUSE) over 6 years ago

  • Target version deleted (2.6)
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0