Project

General

Profile

Actions

Bug #4618

closed

Encoding::ConverterNotFoundErrors on trunk (Windows mingw)

Added by jonforums (Jon Forums) about 11 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 1.9.3dev (2011-04-27 trunk 31364) [i386-mingw32]
Backport:
[ruby-core:35913]

Description

=begin
It appears recent newline trunk code changes cause test failures on Windows as I can't replicate the following failures in test_literal.rb, psych, or openssl on my Arch system.

For the openssl failures, I'm checking whether my recent upgrade from 0.9.8q to 0.9.8r changes things and will report back if needed.

Tested on Windows 7 Ultimate 32-bit with a trunk@31364 built using the RubyInstaller recipes and tdm-gcc 4.5.2.

$ make test
...
#339 test_literal.rb: echo foo #=> "foo\r\n" (expected "foo\n")
#340 test_literal.rb: s = "foo"; echo #{s} #=> "foo\r\n" (expected "foo\n")
FAIL 2/934 tests failed
make: *** [yes-btest-ruby] Error 1

$ make test-all TESTS=psych

  1. Error:
    test_dump_file(TestPsych):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/emitter.rb:20:in end_document' c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/emitter.rb:20:in visit_Psych_Nodes_Document'
    c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/visitor.rb:15:in visit' c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/visitor.rb:5:in accept'
    c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/emitter.rb:13:in block in visit_Psych_Nodes_Stream' c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/emitter.rb:13:in each'
    c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/emitter.rb:13:in visit_Psych_Nodes_Stream' c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/visitor.rb:15:in visit'
    c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/visitors/visitor.rb:5:in accept' c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych/nodes/node.rb:46:in to_yaml'
    c:/projects/rubyinstaller-git/sandbox/ruby19_build/.ext/common/psych.rb:190:in dump' c:/Users/Jon/Documents/RubyDev/ruby-git/test/psych/test_psych.rb:68:in block in test_dump_file'

398 tests, 1112 assertions, 0 failures, 1 errors, 0 skips

$ make test-all TESTS=openssl
...

  1. Error:
    test_add_value(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  2. Error:
    test_aref(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  3. Error:
    test_aset(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  4. Error:
    test_clone(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  5. Error:
    test_constants(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  6. Error:
    test_dup(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  7. Error:
    test_each(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  8. Error:
    test_freeze(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  9. Error:
    test_get_value(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  10. Error:
    test_get_value_ENV(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  11. Error:
    test_initialize(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  12. Error:
    test_initialize_with_empty_file(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  13. Error:
    test_initialize_with_example_file(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  14. Error:
    test_inspect(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  15. Error:
    test_s_load(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  16. Error:
    test_s_parse(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  17. Error:
    test_s_parse_format(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  18. Error:
    test_section(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  19. Error:
    test_sections(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  20. Error:
    test_to_s(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  21. Error:
    test_value(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'

  22. Error:
    test_value_ENV(OpenSSL::TestConfig):
    Encoding::ConverterNotFoundError: code converter not found (universal_newline,crlf_newline)
    c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_config.rb:13:in `setup'
    =end


Related issues 1 (0 open1 closed)

Has duplicate Ruby master - Bug #4619: io.c is broken on WindowsClosednobu (Nobuyoshi Nakada)04/27/2011Actions

Updated by usa (Usaku NAKAMURA) about 11 years ago

  • Status changed from Open to Assigned
  • Assignee set to nobu (Nobuyoshi Nakada)

=begin

=end

Actions #2

Updated by nobu (Nobuyoshi Nakada) about 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r31377.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • io.c (make_writeconv): do not add textmode newline decorator if any
    newline decorator is set already. fixes #4618, fixes #4619
    =end

Updated by jonforums (Jon Forums) about 11 years ago

Thank you Nobu.

All looks good on Win7 32-bit using tdm-gcc 4.5.2 and upgraded to OpenSSL 1.0.0d:

sh-3.1$ ruby --version
ruby 1.9.3dev (2011-05-03 trunk 31412) [i386-mingw32]
sh-3.1$ make test-all TESTS='openssl psych'
...

Running tests:

..........................................................................................
.....................S....................................................................
..........................................................................................
..........................................................................................
..........................................................................................
..........................................................................................
.....

Finished tests in 8.856506s, 61.5367 tests/s, 288.2627 assertions/s.

  1. Skipped:
    test_not_started_session(OpenSSL::TestSSL) [c:/Users/Jon/Documents/RubyDev/ruby-git/test/openssl/test_ssl.rb:158]:
    non socket argument of SSLSocket.new is not supported on this platform

545 tests, 2553 assertions, 0 failures, 0 errors, 1 skips

Actions

Also available in: Atom PDF