Project

General

Profile

Actions

Bug #4188

closed

minitest warnings in 1.9.3

Bug #4188: minitest warnings in 1.9.3

Added by tenderlovemaking (Aaron Patterson) almost 15 years ago. Updated over 14 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 1.9.3dev (2010-12-23 trunk 30299) [x86_64-darwin10.5.0]
Backport:
[ruby-core:33818]

Description

=begin
When running tests with minitests, I get warnings:

/Users/apatterson/.local/lib/ruby/1.9.1/minitest/unit.rb:631: warning: assigned but unused variable - ac
/Users/apatterson/.local/lib/ruby/1.9.1/minitest/unit.rb:632: warning: assigned but unused variable - tc

I've attached a patch that fists the problem.
=end


Files

p.patch (555 Bytes) p.patch tenderlovemaking (Aaron Patterson), 12/23/2010 09:24 AM

Updated by zenspider (Ryan Davis) almost 15 years ago Actions #1

=begin

On Dec 22, 2010, at 16:24 , Aaron Patterson wrote:

Bug #4188: minitest warnings in 1.9.3
http://redmine.ruby-lang.org/issues/show/4188

Author: Aaron Patterson
Status: Open, Priority: Normal
Assigned to: Ryan Davis
ruby -v: ruby 1.9.3dev (2010-12-23 trunk 30299) [x86_64-darwin10.5.0]

When running tests with minitests, I get warnings:

/Users/apatterson/.local/lib/ruby/1.9.1/minitest/unit.rb:631: warning: assigned but unused variable - ac
/Users/apatterson/.local/lib/ruby/1.9.1/minitest/unit.rb:632: warning: assigned but unused variable - tc

this is already fixed in my trunk.

that sounds dirty...

=end

Updated by tenderlovemaking (Aaron Patterson) almost 15 years ago Actions #2

=begin
On Thu, Dec 23, 2010 at 10:11:36AM +0900, Ryan Davis wrote:

On Dec 22, 2010, at 16:24 , Aaron Patterson wrote:

Bug #4188: minitest warnings in 1.9.3
http://redmine.ruby-lang.org/issues/show/4188

Author: Aaron Patterson
Status: Open, Priority: Normal
Assigned to: Ryan Davis
ruby -v: ruby 1.9.3dev (2010-12-23 trunk 30299) [x86_64-darwin10.5.0]

When running tests with minitests, I get warnings:

/Users/apatterson/.local/lib/ruby/1.9.1/minitest/unit.rb:631: warning: assigned but unused variable - ac
/Users/apatterson/.local/lib/ruby/1.9.1/minitest/unit.rb:632: warning: assigned but unused variable - tc

this is already fixed in my trunk.

I'm still seeing it, and my build is r30330. I don't see the fix on the
github repo:

https://github.com/ruby/ruby/blob/trunk/lib/minitest/unit.rb#L631-632

I would link to the lines on ViewVC, but if you go here:

http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/lib/minitest/unit.rb?annotate=30222

Then look for line 631 and 632, it matches the github mirror.

--
Aaron Patterson
http://tenderlovemaking.com/

Attachment: (unnamed)
=end

Updated by naruse (Yui NARUSE) almost 15 years ago Actions #3

  • Status changed from Open to Closed

=begin
This is fixed at r30345, r30347, and r30348
=end

Actions

Also available in: PDF Atom