Bug #3391: Use single exclamation mark instead of double exclamation mark for IRB

• Status: Closed
• Assignee: keiju (Keiju Ishitsuka)
• Target version: 2.0.0
• ruby -v: Ruby 1.9.2-trunk

[diegoviola (Diego Viola)]

=begin
Hello,

I'm adding this patch which changes the "!!" double exclamation marks in lib/irb.rb to use single exclamation marks "!", I think using single exclamation marks are more formal for outputs and Ruby itself.

The patch in question was patched from: http://github.com/ruby/ruby -- Please let me know if you want me to patch from SVN trunk instead.

Thanks and Best Regards,

Diego
=end

[nobu (Nobuyoshi Nakada)]

• Category set to lib
• Status changed from Open to Assigned
• Assignee set to keiju (Keiju Ishitsuka)
• Priority changed from Normal to 3
• Target version set to 2.0.0

=begin

=end

[diegoviola (Diego Viola)]

=begin
When can I expect to see this merged?

Thanks,

Diego
=end

[matz (Yukihiro Matsumoto)]

=begin
Hi,

In message "Re: [ruby-core:30589] [Bug #3391] Use single exclamation mark instead of double exclamation mark for IRB"
on Sat, 5 Jun 2010 08:33:07 +0900, Diego Viola [e-mail] writes:

|I'm adding this patch which changes the "!!" double exclamation marks in lib/irb.rb to use single exclamation marks "!", I think using single exclamation marks are more formal for outputs and Ruby itself.
|
|The patch in question was patched from: http://github.com/ruby/ruby -- Please let me know if you want me to patch from SVN trunk instead.

Although your claim is reasonable, we don't want to introduce any
incompatibility right now. So we will merge the patch on trunk, for
sometime in the future.

						matz.

=end

[matz (Yukihiro Matsumoto)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

=begin
This issue was solved with changeset r28363.
Diego, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

[diegoviola (Diego Viola)]

=begin
Thanks Matz, Ruby FTW.
=end

[diegoviola (Diego Viola)]

=begin
Why isn't this change included in Ruby 1.9.2 RC1?
=end

[runpaint (Run Paint Run Run)]

=begin

Why isn't this change included in Ruby 1.9.2 RC1?

It was committed after the code freeze. See http://redmine.ruby-lang.org/wiki/ruby-19/ReleasePlan . :-)
=end

[diegoviola (Diego Viola)]

=begin
I see. Is there any chance it will be merged in future versions?

Thanks,

Diego
=end

[runpaint (Run Paint Run Run)]

=begin
Certain. :-) It's been merged into trunk now, so the next release branched from trunk will have your patch applied. In addition, people who run bleeding-edge Ruby, i.e. build from trunk themselves, already have your patch. :-)
=end

[diegoviola (Diego Viola)]

=begin
Thanks
=end