Project

General

Profile

Backport #2556

Should r24500 be backported to 1.8?

Added by brixen (Brian Shirai) over 9 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:27401]

Description

=begin
Should http://redmine.ruby-lang.org/repositories/diff/ruby-19?rev=24500 be backported to 1.8?

$ ruby -v -rdate -e 'p Date.strptime("2010/1", "%Y/%W").to_s'
ruby 1.8.6 (2008-08-11 patchlevel 287) [universal-darwin9.0]
"2010-01-10"
$ ruby1.8.7 -v -rdate -e 'p Date.strptime("2010/1", "%Y/%W").to_s'
ruby 1.8.7 (2009-12-24 patchlevel 248) [i686-darwin9.8.0]
"2010-01-10"
$ ruby1.9 -v -rdate -e 'p Date.strptime("2010/1", "%Y/%W").to_s'
ruby 1.9.2dev (2009-12-16 trunk 26107) [i386-darwin9.8.0]
"2010-01-04"

Monday of the first week of 2010 is clearly not 1/10, so the change in r24500 would seem to be a bug fix. I searched for a ticket for the change made in r24500 but could not find one.

Thanks,
Brian
=end

Associated revisions

Revision ffd9245a
Added by knu (Akinori MUSHA) about 8 years ago

Backport r24500; fixes #2556.

  • lib/date.rb (complete_frags): Monday must be suitable for %W's default day.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@32574 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 32574
Added by knu (Akinori MUSHA) about 8 years ago

Backport r24500; fixes #2556.

  • lib/date.rb (complete_frags): Monday must be suitable for %W's default day.

History

#1

Updated by naruse (Yui NARUSE) over 9 years ago

  • Status changed from Open to Assigned
  • Assignee set to knu (Akinori MUSHA)

=begin

=end

#2

Updated by knu (Akinori MUSHA) over 9 years ago

  • Assignee changed from knu (Akinori MUSHA) to tadf (tadayoshi funaba)

=begin
Can we backport this?
=end

#3

Updated by tadf (tadayoshi funaba) about 9 years ago

=begin
maybe ok.
=end

#4

Updated by tadf (tadayoshi funaba) about 9 years ago

  • Assignee changed from tadf (tadayoshi funaba) to knu (Akinori MUSHA)

=begin

=end

#5

Updated by knu (Akinori MUSHA) about 8 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r32574.
Brian, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


Backport r24500; fixes #2556.

  • lib/date.rb (complete_frags): Monday must be suitable for %W's default day.

Updated by knu (Akinori MUSHA) about 8 years ago

  • Status changed from Closed to Assigned
  • Assignee changed from knu (Akinori MUSHA) to shyouhei (Shyouhei Urabe)

Backport to 1.8.7 is up to you.

#7

Updated by shyouhei (Shyouhei Urabe) over 2 years ago

  • Status changed from Assigned to Closed

Also available in: Atom PDF