Bug #20409: Missing reporting some invalid breaks

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN

[kddnewton (Kevin Newton)]

[kddnewton (Kevin Newton)]

Sorry hit enter too soon...

def a
  break
rescue
  b while c
end

def a
  break
ensure
  b while c
end

[kddnewton (Kevin Newton)]

I think

END { break }

should also be a syntax error, as it seems to always result in a LocalJumpError, but I could be wrong.

[nobu (Nobuyoshi Nakada)]

It reproduces only with a modifier while/until, even without rescue/ensure.

begin
  break
  nil while false
end

[Earlopain (Earlopain _)]

Today I get a syntax error for all the examples in both parsers except for END { break }. Can this be closed or should END { break } still be considered?

[Earlopain (Earlopain _)]

I think END should be syntax error. The same is already true for BEGIN, seems inconsistent.

[kddnewton (Kevin Newton)]

I think END { break } should still be a syntax error, as it always results in an error.

[Earlopain (Earlopain _)]

I added it to the dev meeting and implemented it in https://github.com/ruby/prism/pull/3707

[matz (Yukihiro Matsumoto)]

Yes, it is OK to make it SyntaxError.

Matz.

[Earlopain (Earlopain _)]

• Status changed from Open to Closed

Applied in changeset git|558c10413990cb08b7750895b572b0b59eed0d28.

---

[ruby/prism] Reject END { break } for Ruby 4.0

For [Bug #20409]

https://github.com/ruby/prism/commit/4848eb344e

[kddnewton (Kevin Newton)]

• Status changed from Closed to Open

Re-opening, we need a syntax error for parse.y.

[nobu (Nobuyoshi Nakada)]

Is it intentional that END {next} is valid, whereas BEGIN {next} is a syntax error?

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset git|2f9432d2114833b105577ad72e323990daf5101e.

---

[Bug #20409] Make break and redo in END syntax error

[matz (Yukihiro Matsumoto)]

Not intentional. It is just a leftover from the old implementation. The inconsistency should be fixed eventually.

Matz.

[Earlopain (Earlopain _)]

Here it is https://github.com/ruby/ruby/pull/16936 (I did prism and parsey). Makes the implementaion easier to not have to special-case this