Project

General

Profile

Actions

Bug #20277

closed

Remove stale `String` test conditionals

Added by nobu (Nobuyoshi Nakada) 9 months ago. Updated 8 months ago.


Description

I found three instance variables in TestString in test/ruby/test_string.rb.

These select assertions:

  • @aref_re_nth = true
    Enables String#[regexp, index] assertions.

  • @aref_re_silent = false
    Assignment to unmatched region silently fails, if true.

  • @aref_slicebang_silent = true
    Out of range argument to String#slice! returns nil, not raising an exception.

These instance variables for conditional execution have remained unchanged for nearly twenty years, since YARV merger.
It is questionable whether these behaviors can be changed anymore.

So I propose to remove these conditionals.

Updated by nobu (Nobuyoshi Nakada) 8 months ago

  • Description updated (diff)
  • Assignee set to ko1 (Koichi Sasada)
Actions #3

Updated by nobu (Nobuyoshi Nakada) 8 months ago

  • Status changed from Open to Closed

Applied in changeset git|76bd586330d98b8a0023ff35c7fa6014ba3a4715.


[Bug #20277] Remove stale String test conditionals

These instance variables for conditional execution have remained
unchanged for nearly twenty years, since YARV merger.

Actions

Also available in: Atom PDF

Like1
Like0Like0Like0