Project

General

Custom queries

Profile

ActionsLike0

Feature #1831

closed

Suggestion: warn on repeated character in character class

Added by candlerb (Brian Candler) over 15 years ago. Updated over 13 years ago.

Status:
Closed
Target version:
[ruby-core:24593]

Description

=begin
Suggestion: warn if the same character appears more than once in a character class (or more restrictedly: if the character ':' appears both at the start and end of a character class)

This is to give some indication of the problem if you do the following:

RUBY_DESCRIPTION
=> "ruby 1.9.2dev (2009-07-18 trunk 24186) [i686-linux]"
$WARN=true
=> true
"uber" =~ /[:lower:]/
=> 2
=end


Files

ruby-core-24593.patch (18.2 KB) ruby-core-24593.patch naruse (Yui NARUSE), 07/31/2009 08:00 AM
Like0Actions #1

Updated by candlerb (Brian Candler) over 15 years ago

=begin
That should have said $VERBOSE=true, but it makes no difference
=end

Like0Actions #2

Updated by naruse (Yui NARUSE) over 15 years ago

  • File ruby-core-24593_1_.patch added

=begin
I'm interested in your suggestion, and wrote a patch.
=end

Like0Actions #3

Updated by naruse (Yui NARUSE) over 15 years ago

=begin

=end

Like0Actions #4

Updated by naruse (Yui NARUSE) over 15 years ago

  • File deleted (ruby-core-24593_1_.patch)

=begin

=end

Like0Actions #5

Updated by naruse (Yui NARUSE) over 15 years ago

=begin
Patch updated.

Matz, can I commit this patch?
=end

Like0Actions #6

Updated by matz (Yukihiro Matsumoto) over 15 years ago

=begin
Hi,

In message "Re: [ruby-core:24627] [Feature #1831] Suggestion: warn on repeated character in character class"
on Fri, 31 Jul 2009 08:01:30 +0900, Yui NARUSE writes:

|Patch updated.
|
|Matz, can I commit this patch?

OK.

=end

Like0Actions #7

Updated by naruse (Yui NARUSE) over 15 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

=begin
Applied in changeset r24387.
=end

ActionsLike0

Also available in: Atom PDF