Project

General

Profile

Bug #16770

Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times

Added by MSP-Greg (Greg L) 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.8.0dev (2020-04-08T04:28:13Z master 9e6e39c351) [x64-mingw32]
[ruby-core:97750]

Description

Inspecting logs both here and in ruby-loco, the following commit greatly increased compile time in MinGW builds:

https://github.com/ruby/ruby/commit/6163a4e1b33ed7df27d0c37e835ce04407857a16

In ruby-loco, the make/compile time jumped from 9:23 to 34:43.

Here:

after  32:22 - https://github.com/ruby/ruby/runs/569706642
before 11:11 - https://github.com/ruby/ruby/runs/569624968 [win32] Moved `MSC_VER` to verconf.mk... 


Related issues

Related to Ruby master - Bug #16772: Build becomes slow with CIFS mounted srcdirClosedshyouhei (Shyouhei Urabe)Actions
#1

Updated by MSP-Greg (Greg L) 7 months ago

  • Subject changed from Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW compile time to Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times

Updated by Eregon (Benoit Daloze) 6 months ago

Is it due to that specific commit, or rather due to https://github.com/ruby/ruby/pull/2991 ?

Updated by shyouhei (Shyouhei Urabe) 6 months ago

  • Assignee set to shyouhei (Shyouhei Urabe)
#4

Updated by shyouhei (Shyouhei Urabe) 6 months ago

  • Related to Bug #16772: Build becomes slow with CIFS mounted srcdir added

Updated by MSP-Greg (Greg L) 6 months ago

Eregon (Benoit Daloze)

I apologize for the possible confusion. When I opened the issue, I woke up, and all three builds (Actions - mingw & mswin, AppVeyor - mingw) took much longer for both build & test. I mentioned the CI logs that showed when it occurred, but CI isn't done on every commit. I should have made clear that I didn't bisect the issue, I just determined a good/bad range of commits.

Regardless, as of 2020-04-10 master 878e21c6cd, all three builds have returned to normal build & test times.

shyouhei (Shyouhei Urabe)

Thank you.

I may be a little sensitive about master, as I try to encourage external repos/gems to test with it. Doing so allows them to know that it's very likely their code will work with new Ruby releases. It also provides a good feedback loop of info for ruby/ruby.

Ok to close.

Updated by Eregon (Benoit Daloze) 6 months ago

  • Status changed from Open to Closed

I guess 443389effc37308ce1a3c3a840082a344fc6af56 probably fixed this.

Also available in: Atom PDF