Bug #16762: Ruby is not properly fortified on armv7hl

• Status: Closed
• Priority: Normal
• Assignee: ioquatix (Samuel Williams)
• Target version: -
• ruby -v: ruby 2.8.0dev (2020-04-03 master 810d66f3e7) [armv7hl-linux]
• Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN

[vo.x (Vit Ondruch)]

The issue is similar to #15335 and the fix is also similar:

diff --git a/coroutine/arm32/Context.S b/coroutine/arm32/Context.S
index b66db29622..596284b5cf 100644
--- a/coroutine/arm32/Context.S
+++ b/coroutine/arm32/Context.S
@@ -24,3 +24,7 @@ coroutine_transfer:

    # Restore callee state (8 registers program counter)
    pop {r4-r11,pc}
+
+#if defined(__linux__) && defined(__ELF__)
+.section .note.GNU-stack,"",%progbits
+#endif

It seems to be introduced by https://github.com/ruby/ruby/pull/2995

[vo.x (Vit Ondruch)]

• Related to Bug #15335: Ruby 2.6.0 is not properly fortified added

[vo.x (Vit Ondruch)]

I'd still love to see this fixed.

[mame (Yusuke Endoh)]

• Assignee set to ioquatix (Samuel Williams)
• Status changed from Open to Assigned

[ioquatix (Samuel Williams)]

https://github.com/ruby/ruby/pull/3866

[ioquatix (Samuel Williams)]

It passed arm32 on travis (as expected), so I merged it. Thanks everyone!

[ioquatix (Samuel Williams)]

• Status changed from Assigned to Closed