Project

General

Profile

Actions

Bug #1627

closed

Kernel.require Should Canonicalise Paths

Added by runpaint (Run Paint Run Run) over 15 years ago. Updated over 13 years ago.

Status:
Closed
Assignee:
-
Target version:
ruby -v:
ruby 1.9.2dev (2009-06-13 trunk 23682) [i686-linux]
Backport:
[ruby-core:23845]

Description

=begin
Kernel.require on 1.9 is far saner than 1.8 with respect to normalizing path names before storing them in $". To use the example from the rdoc, require 'a' and require './a' are now correctly regarded as identical, causing 'a' to be loaded only once. (I have a separate ticket open to update the rdoc).

However, there are still a couple of edge cases when paths aren't normalised.

 >> require '/tmp/../tmp/c.rb'
 c.rb
 => true
 >> require '/tmp/c.rb'
 c.rb
 => true
 >> require '/../../../tmp/c.rb'
 c.rb
 => true
 >> $".grep /c.rb/
 => ["/tmp/../tmp/c.rb", "/tmp/c.rb", "/../../../tmp/c.rb"]

Another is that multiple consecutive separators are not collapsed:

 >> require '/tmp/c.rb'
 c.rb
 => true
 >> require '/tmp//c.rb'
 c.rb
 => true
 >> $".grep /c.rb/
 => ["/tmp/c.rb", "/tmp//c.rb"]

However, tilde expansion is handled correctly:

 >> require '/tmp/c'
 c.rb
 => true
 >> require '~/../../tmp/c'
 => false
 >> $".grep /c.rb/
 => ["/tmp/c.rb"]

In all cases the path should be expanded and made absolute before being stored in $". This would presumably aid performance, avoid files being inadvertently loaded multiple times, and be more consistent.

(As an aside, all filenames in $" on my system are absolute apart from 'enumerator.so', which is relative. It would be more consistent if all such paths were absolute.)
=end

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0