Bug #15339: CI - add checks for std-lib CLI ?

• Status: Closed
• Assignee: hsbt (Hiroshi SHIBATA)
• Target version: -
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN

[MSP-Greg (Greg L)]

Currently, CI is largely ignorant of the install.

Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.

See GitHub PR #2028.

[MSP-Greg (Greg L)]

• File pr_2028.patch added

Sorry for not mentioning it, but GH PR is just for Appveyor. Not sure if code should be added to all Travis builds...

PR CI failed for all three builds on Appveyor. All errors similar to:

\usr\bin\bundle --version
C:/usr/bin/bundle.cmd:33:in `load': cannot load such file -- C:/usr/lib/ruby/gems/2.6.0/gems/bundler-2.0.0.pre.1/exe/bundle (LoadError)
	from C:/usr/bin/bundle.cmd:33:in `<main>'

Command exited with code 1

Something must be wrong with the bundler install code.

Patch attached.

How about creating this check in make task "make test" or "make test-all"?

[MSP-Greg (Greg L)]

@junaruga

1. I believe I have seen discussions on whether make install should be included in CI or not.

2. The test suites can be run before make install.

3. I'm not a good choice for making changes re Makefile, especially for cross platform use.

Given the above, I thought starting with Ruby's own Windows CI would be a good start.

JFYI, ruby-loco is running every test suite except basic from install (without using make). The build folder could be deleted beforehand. There were a few files that needed changing for that...

Thanks, Greg

[MSP-Greg (Greg L)]

• File deleted (pr_2028.patch)

[MSP-Greg (Greg L)]

• File pr_2028.patch pr_2028.patch added

Added 3 lines to rbinstall.rb, added bundle_ruby to Bundler's executables.

Both are minor fixups to r65963. Passes on Appveyor. Patch file updated. Nothing changed re Travis...

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned
• Assignee set to hsbt (Hiroshi SHIBATA)

[hsbt (Hiroshi SHIBATA)]

• Status changed from Assigned to Closed

Hi Greg.

Thanks for your report.
This is fixed ar r66384 by @usa (Usaku NAKAMURA).

I will consider to add cli check to our CI after Ruby 2.6 releasing.

[naruse (Yui NARUSE)]

• Has duplicate Bug #15407: bundle, bundler, irb, rdoc, ri commands broken if --program-suffix configure option is used added