Project

General

Profile

Bug #15164

mkmf doesn't work with miniruby on Windows

Added by naruse (Yui NARUSE) 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:89177]

Description

After r59449 nmake failes to run when making ripper and so on.
It because miniruby sets UTF-8 encoding even though the content is CP932 (on Japanese Windows).
It should set ASCII-8BIT and handle as it is.

ripper:
"       Could not be configured. It will not be installed."
"       C:/ruby-trunk/lib/mkmf.rb:1560: invalid byte sequence in UTF-8"
"       Check ext/ripper/mkmf.log for more details."
*** Fix the problems, then remove these directories and try again if you want.

Note that recent Windows sets PATH to paths under %APPDATA% for example
C:\Users<UserNameInANSI>\AppData\Local\Microsoft\WindowsApps

Associated revisions

Revision 7f0d337b
Added by nobu (Nobuyoshi Nakada) 9 months ago

fallback env encoding to ASCII-8BIT

  • hash.c (env_enc_str_new): as no locale/filesystem encoding is available in miniruby on Windows, fallback the encoding to ASCII-8BIT so it is valid encoding when the conversion failed. [ruby-core:89177] [Bug #15164]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 64860
Added by nobu (Nobuyoshi Nakada) 9 months ago

fallback env encoding to ASCII-8BIT

  • hash.c (env_enc_str_new): as no locale/filesystem encoding is available in miniruby on Windows, fallback the encoding to ASCII-8BIT so it is valid encoding when the conversion failed. [ruby-core:89177] [Bug #15164]

Revision 64860
Added by nobu (Nobuyoshi Nakada) 9 months ago

fallback env encoding to ASCII-8BIT

  • hash.c (env_enc_str_new): as no locale/filesystem encoding is available in miniruby on Windows, fallback the encoding to ASCII-8BIT so it is valid encoding when the conversion failed. [ruby-core:89177] [Bug #15164]

Revision 49d542f6
Added by nagachika (Tomoyuki Chikanaga) 9 months ago

merge revision(s) 64860,64861: [Backport #15164]

    fallback env encoding to ASCII-8BIT

    * hash.c (env_enc_str_new): as no locale/filesystem encoding is
      available in miniruby on Windows, fallback the encoding to
      ASCII-8BIT so it is valid encoding when the conversion failed.
      [ruby-core:89177] [Bug #15164]

    * properties.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 64982
Added by nagachika (Tomoyuki Chikanaga) 9 months ago

merge revision(s) 64860,64861: [Backport #15164]

fallback env encoding to ASCII-8BIT

* hash.c (env_enc_str_new): as no locale/filesystem encoding is
  available in miniruby on Windows, fallback the encoding to
  ASCII-8BIT so it is valid encoding when the conversion failed.
  [ruby-core:89177] [Bug #15164]

* properties.

History

#1

Updated by naruse (Yui NARUSE) 9 months ago

  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED
  • Description updated (diff)
#2

Updated by nobu (Nobuyoshi Nakada) 9 months ago

  • Status changed from Open to Closed

Applied in changeset trunk|r64860.


fallback env encoding to ASCII-8BIT

  • hash.c (env_enc_str_new): as no locale/filesystem encoding is available in miniruby on Windows, fallback the encoding to ASCII-8BIT so it is valid encoding when the conversion failed. [ruby-core:89177] [Bug #15164]

Updated by nagachika (Tomoyuki Chikanaga) 9 months ago

  • Backport changed from 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONE

ruby_2_5 r64982 merged revision(s) 64860,64861.

Also available in: Atom PDF