Bug #15041: [PATCH] cont.c: set th->root_fiber to current fiber at fork

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE

[normalperson (Eric Wong)]

cont.c: set th->root_fiber to current fiber at fork

Otherwise, th->root_fiber can point to an invalid Fiber,
because Fibers do not live across fork. So consider
whatever Fiber is running the root fiber.

[ko1 (Koichi Sasada)]

(I'm not sure why fork removes other fibers, but)
I think it is okay. let's try.

[normalperson (Eric Wong)]

• Status changed from Open to Closed

Applied in changeset trunk|r64589.

---

cont.c: set th->root_fiber to current fiber at fork

Otherwise, th->root_fiber can point to an invalid Fiber,
because Fibers do not live across fork. So consider
whatever Fiber is running the root fiber.

[ruby-core:88723] [Bug #15041]

[normalperson (Eric Wong)]

[e-mail] wrote:

(I'm not sure why fork removes other fibers, but)

fib = Fiber.new { puts " HI" }
fork { fib.resume }
Process.waitall

Shows me: `resume': fiber called across stack rewinding barrier (FiberError)

If we reimplement Fiber entirely with Ruby bytecode, then we
can we can jump around anywhere (and migrate fibers across
threads). But we lose C extension compatibility.

I think it is okay. let's try.

OK, r64589

[ko1 (Koichi Sasada)]

On 2018/08/29 17:09, Eric Wong wrote:

Shows me: `resume': fiber called across stack rewinding barrier (FiberError)

Yes, I tried similar code.
Not sure why...

Nobu?

--
// SASADA Koichi at atdot dot net

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE

ruby_2_5 r66818 merged revision(s) 64589,64593.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE to 2.3: REQUIRED, 2.4: DONE, 2.5: DONE

ruby_2_4 r66968 merged revision(s) 64589,64593.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.3: REQUIRED, 2.4: DONE, 2.5: DONE to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE