Bug #14494: [PATCH] tool/m4/ruby_replace_type.m4 use AC_CHECK_TYPES for HAVE_* macros

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN

[normalperson (Eric Wong)]

tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros

Without this, HAVE_CLOCKID_T goes undefined and I can't
USE_MONOTONIC_COND in thread_pthread.c :<

[normalperson (Eric Wong)]

[e-mail] wrote:

Without this, HAVE_CLOCKID_T goes undefined and I can't
USE_MONOTONIC_COND in thread_pthread.c :<

On a side note, I also realized we have no use for realtime
condvars, only monotonic ones....

[normalperson (Eric Wong)]

Eric Wong wrote:

On a side note, I also realized we have no use for realtime
condvars, only monotonic ones....

Yep, and drop more code, too:
https://80x24.org/spew/[e-mail]/raw

(I also reused the condattr since pthread_cond_init does not modify it)

[nobu (Nobuyoshi Nakada)]

Indeed, it was a mistake.
Do you think HAVE_ macros should be defined for all RUBY_REPLACE_TYPE?

[normalperson (Eric Wong)]

[e-mail] wrote:

Indeed, it was a mistake.
Do you think HAVE_ macros should be defined for all RUBY_REPLACE_TYPE?

Probably, but I was wondering what your opinion is.
We only use RUBY_REPLACE_TYPES for common t types, so I don't
think there's any conflicts with function names for HAVE.

[nobu (Nobuyoshi Nakada)]

I have no particular opinion on it, probably it'd be convenient.

• Status changed from Open to Closed

Applied in changeset trunk|r62495.

---

tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros

AC_CHECK_TYPE (no "S") does not define HAVE_* macros for types,
so use AC_CHECK_TYPES (with "S") instead. Without this,
HAVE_CLOCKID_T goes undefined and I can't USE_MONOTONIC_COND in
thread_pthread.c :<

Fixes: r62446 (git 673ae0e3c9cefd693ef82f19a6761e147fc6de93)
("configure.ac: check clockid_t with necessary headers")

• tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros
  [ruby-core:85659] [Bug #14494]