Project

General

Profile

Actions

Bug #14121

closed

test-all - rename duplicate classes for consistent test count

Added by MSP-Greg (Greg L) over 6 years ago. Updated over 4 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.5.0dev (2017-11-20 trunk 60862) [x64-mingw32]
[ruby-core:83841]

Description

test-all reports varying test counts from build to build. This seems to be due to duplicate class names in the test suite.

I pushed PR 1763 to the git repo with several renamed classes.

I've been using the patch in ruby-loco MinGW builds. The test summary page Ruby MinGW Test Results has shown consistent results.

Also, I did a build in my fork, which showed a test count of 16,826, which matches the test count in the PR build.

In addition to PR, patch attached. Thanks, Greg


Files

test-class_renames.patch (12.4 KB) test-class_renames.patch Patches used in GitHub PR 1763 MSP-Greg (Greg L), 11/20/2017 05:00 PM

Updated by shevegen (Robert A. Heiler) over 6 years ago

I like that you use an overview (the html page) for people to have a look at.

Updated by MSP-Greg (Greg L) over 6 years ago

shevegen (Robert A. Heiler) wrote:

I like that you use an overview (the html page) for people to have a look at.

Thanks. That whole site (the doc side of it) started because I wanted to look at my code on a tablet. Now, the test results page and the updates for Ruby, Rails, & AWS are a single mouse click.

If you work much on Appveyor & Travis, I've also got summaries of their builds at appveyor-ruby and travis-ruby. It's interesting to see the differences in compilers and libraries...

Greg

Updated by jeremyevans0 (Jeremy Evans) over 4 years ago

  • Status changed from Open to Closed
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0