Bug #14082: Enumerator#size from Enumerable#cycle returns 0 when the object is empty

• Status: Closed
• Assignee: marcandre (Marc-Andre Lafortune)
• Target version: -
• ruby -v: ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin16]
• Backport: 2.3: DONE, 2.4: DONE

[kachick (Kenichi Kamiya)]

github: https://github.com/ruby/ruby/pull/1742

Is this an intentional behavior?

p([].cycle.size) #=> 0
p({}.cycle.size) #=> Infinity 

Array#cycle already special handled empty arrays. So similar behavior in Enumerable#cycle with the #size sounds reasonable to me.

[marcandre (Marc-Andre Lafortune)]

• Assignee set to marcandre (Marc-Andre Lafortune)

Good catch, great patch :-)

[marcandre (Marc-Andre Lafortune)]

• Status changed from Open to Closed

Applied in changeset trunk|r60666.

---

Fix size on Enumerable#cycle when the size is 0 [Bug #14082].

Patch by Kenichi Kamiya

[marcandre (Marc-Andre Lafortune)]

• Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN to 2.3: REQUIRED, 2.4: REQUIRED

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED to 2.3: REQUIRED, 2.4: DONE

[usa (Usaku NAKAMURA)]

• Backport changed from 2.3: REQUIRED, 2.4: DONE to 2.3: DONE, 2.4: DONE

ruby_2_3 r62827 merged revision(s) 60666,60667,60668.