Bug #13843: [PATCH] RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems

• Status: Rejected
• Assignee: hsbt (Hiroshi SHIBATA)
• Target version: -
• ruby -v: ruby 2.5.0dev (2017-08-25 trunk 59654) [x64-mingw32]
• Backport: 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED

[MSP-Greg (Greg L)]

Currently, the file lib/rubygems/resolver.rb differs between ruby/ruby and rubygems/rubygems in the search_for method.

Attached patch aligns them and adds the test for it, which is also missing from ruby/ruby. Tested against MinGW trunk builds and Travis.

See rubygem/rubygems PR 1993

[MSP-Greg (Greg L)]

• Subject changed from RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems to [PATCH} RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems

[MSP-Greg (Greg L)]

• Subject changed from [PATCH} RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems to [PATCH] RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems

[MSP-Greg (Greg L)]

At rubygems/rubygems, the patch for resolver.rb was accepted first, then the patch to extend appveyor testing to include trunk was accepted.

Appveyor results and Travis results.

Sorry if I'm being a PITA, but since I'm testing a lot these days, the idea that a trunk build from last week (gem -v 2.6.12) which had a gem update --system done would have different code than a current build (gem -v 2.6.13) is not another vector/dimension I want present in things to keep track of...

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned
• Assignee set to hsbt (Hiroshi SHIBATA)

[hsbt (Hiroshi SHIBATA)]

• Status changed from Assigned to Rejected
• Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED

It's already merged into Rubygems master. we will merge this on Ruby 2.5.0.