Feature #13502: remove unused Array#to_s implementation

• Status: Open
• Assignee: -
• Target version: -

[colby (Colby Swandale)]

Hello Ruby Team!

First time i've make a commit request, hopefully not the last :)

While browsing the src of ruby, specifically array.c i noticed that Array#to_s is an alias of Array#inspect but the implementation of Array#to_s still remains in src.

I tried to find a reason why the implementation still remains in src without any luck but let me know if there is a reason why.

• array.c: remove rb_ary_to_s function and remove static keyword from rb_ary_inspect
• include/ruby/intern.h: declare rb_ary_inspect and alias rb_ary_to_s to rb_ary_inspect

Thanks in advance.

[colby (Colby Swandale)]

• File deleted (0001-remove-array-to_s-implementation)

[colby (Colby Swandale)]

• File 0001-remove-array-to_s-implementation.patch added

[normalperson (Eric Wong)]

Thanks for the report. I think we need to keep an alias for
rb_ary_to_s in intern.h for backwards-compatibility. intern.h
is (unfortunately) part of the public API which 3rd-party
extensions may depend on.

Perhaps use the RUBY_ALIAS_FUNCTION macro to preserve the
alias in intern.h, but remove it from array.c.

Thanks.

[colby (Colby Swandale)]

Thanks for the feedback Eric. I'll work on that.

[colby (Colby Swandale)]

• File 0001-remove-array-to_s-implementation.patch added
• Description updated (diff)

[colby (Colby Swandale)]

• File deleted (0001-remove-array-to_s-implementation.patch)

[colby (Colby Swandale)]

• File 0001-remove-Array-to_s-c-implementation.patch 0001-remove-Array-to_s-c-implementation.patch added

[colby (Colby Swandale)]

• File deleted (0001-remove-array-to_s-implementation.patch)

[hsbt (Hiroshi SHIBATA)]

• Tracker changed from Misc to Feature