Project

General

Profile

Bug #13170

OpenSSL::X509::Name#eql? broken in Ruby 2.4.0

Added by Iristyle (Ethan Brown) over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin15]
[ruby-core:79310]

Description

Previously the behavior in Ruby 2.3.1 and earlier was:

[1] pry(main)> OpenSSL::X509::Name.new([['CN', 'foo']]).eql?(OpenSSL::X509::Name.new([['CN', 'bar']]))
=> false
[2] pry(main)> OpenSSL::X509::Name.new([['CN', 'foo']]).eql?(OpenSSL::X509::Name.new([['CN', 'foo']]))
=> true
[3] pry(main)> RUBY_VERSION
=> "2.3.1"

In Ruby 2.4.0, the evaluation is backwards:

[1] pry(main)> OpenSSL::X509::Name.new([['CN', 'foo']]).eql?(OpenSSL::X509::Name.new([['CN', 'bar']]))
=> true
[2] pry(main)> OpenSSL::X509::Name.new([['CN', 'foo']]).eql?(OpenSSL::X509::Name.new([['CN', 'foo']]))
=> false
[3] pry(main)> RUBY_VERSION
=> "2.4.0"

This is due to the implementation of the function at https://github.com/ruby/ruby/blob/aab0d67a1ff5190ff7a951e40cee742210302aed/ext/openssl/ossl_x509name.c#L366-L379

static VALUE ossl_x509name_eql(VALUE self, VALUE other)

Previously in 2.3.1 code returned (based on result = ossl_x509name_cmp0(self, other);):

return (result == 0) ? Qtrue : Qfalse;

Now the code has introduced a logic bug in 2.4.0 as of commit https://github.com/ruby/ruby/commit/aab0d67a1ff5190ff7a951e40cee742210302aed:

return ossl_x509name_cmp0(self, other) ? Qtrue : Qfalse;

The code should be:

return (ossl_x509name_cmp0(self, other) == 0) ? Qtrue : Qfalse;

Also available in: Atom PDF