Project

General

Profile

Bug #13170

Updated by Iristyle (Ethan Brown) over 3 years ago

Previously the behavior in Ruby `2.3.1` and earlier was: 

 ``` 
 [1] pry(main)> OpenSSL::X509::Name.new([['CN', 'foo']]).eql?(OpenSSL::X509::Name.new([['CN', 'bar']])) 
 => false 
 [2] pry(main)> OpenSSL::X509::Name.new([['CN', 'foo']]).eql?(OpenSSL::X509::Name.new([['CN', 'foo']])) 
 => true 
 [3] pry(main)> RUBY_VERSION 
 => "2.3.1" 
 ``` 

 In Ruby 2.4.0, the evaluation is backwards: 

 ``` 
 [1] pry(main)> OpenSSL::X509::Name.new([['CN', 'foo']]).eql?(OpenSSL::X509::Name.new([['CN', 'bar']])) 
 => true 
 [2] pry(main)> OpenSSL::X509::Name.new([['CN', 'foo']]).eql?(OpenSSL::X509::Name.new([['CN', 'foo']])) 
 => false 
 [3] pry(main)> RUBY_VERSION 
 => "2.4.0" 
 ``` 

 This is due to the implementation of    the function at https://github.com/ruby/ruby/blob/aab0d67a1ff5190ff7a951e40cee742210302aed/ext/openssl/ossl_x509name.c#L366-L379 

 ``` 
 static `static VALUE ossl_x509name_eql(VALUE self, VALUE other) 
 ``` other)` 

 Previously in `2.3.1` code returned (based on `result = ossl_x509name_cmp0(self, other);`): 

 ``` 
 return `return (result == 0) ? Qtrue : Qfalse; 
 ``` Qfalse;` 

 Now the code has introduced a logic bug in 2.4.0 as of commit https://github.com/ruby/ruby/commit/aab0d67a1ff5190ff7a951e40cee742210302aed: 

 ``` 
 return `return ossl_x509name_cmp0(self, other) ? Qtrue : Qfalse; 
 ``` Qfalse;` 

 The code should instead be: 

 ``` 
 return `return (ossl_x509name_cmp0(self, other) == 0) ? Qtrue : Qfalse; 
 ``` Qfalse;`

Back