Bug #1278: Fix compiler warnings in openssl extension

• Status: Closed
• Assignee: -
• Target version: 1.9.1
• ruby -v: ruby 1.9.2dev (2009-03-12) [i386-mswin32_90]

[cfis (Charlie Savage)]

=begin
Attach patch fixes a bunch of compiler errors with the openssl extension on Windows with VC 2008 with -W3 warnings. Biggest change is fixing the function signatures for calls to ASN1_dup.

---

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/openssl -MDd -Zi -RTC1 -W3 -wd4996 -Od -Zm600 -DRUBY_EXTCONF_H="extconf.h" -I. -I./.. -I./../missing -DLIBRUBY_SO="ruby19.dll" -IC:\Development\msvc\include -Foossl_engine.obj -c -Tc../.././../ext/openssl/ossl_engine.c ossl_engine.c
../.././../ext/openssl/ossl_engine.c(122) : warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)'

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/openssl -MDd -Zi -RTC1 -W3 -wd4996 -Od -Zm600 -DRUBY_EXTCONF_H="extconf.h" -I. -I./.. -I./../missing -DLIBRUBY_SO="ruby19.dll" -IC:\Development\msvc\include -Foossl_pkcs7.obj -c -Tc../.././../ext/openssl/ossl_pkcs7.c ossl_pkcs7.c
../.././../ext/openssl/ossl_pkcs7.c(89) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'i2d_of_void (__cdecl *)'
../.././../ext/openssl/ossl_pkcs7.c(102) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'i2d_of_void (__cdecl *)'
../.././../ext/openssl/ossl_pkcs7.c(115) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'i2d_of_void (__cdecl *)'
../.././../ext/openssl/ossl_pkcs7.c(128) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'i2d_of_void (__cdecl *)'

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/openssl -MDd -Zi -RTC1 -W3 -wd4996 -Od -Zm600 -DRUBY_EXTCONF_H="extconf.h" -I. -I./.. -I./../missing -DLIBRUBY_SO="ruby19.dll" -IC:\Development\msvc\include -Foossl_pkey.obj -c -Tc../.././../ext/openssl/ossl_pkey.c ossl_pkey.c
../.././../ext/openssl/ossl_pkey.c(180) : warning C4018: '<=' : signed/unsigned mismatch

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/openssl -MDd -Zi -RTC1 -W3 -wd4996 -Od -Zm600 -DRUBY_EXTCONF_H="extconf.h" -I. -I./.. -I./../missing -DLIBRUBY_SO="ruby19.dll" -IC:\Development\msvc\include -Foossl_pkey_dsa.obj -c -Tc../.././../ext/openssl/ossl_pkey_dsa.c ossl_pkey_dsa.c
../.././../ext/openssl/ossl_pkey_dsa.c(260) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'i2d_of_void (__cdecl *)'
../.././../ext/openssl/ossl_pkey_dsa.c(370) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'i2d_of_void (__cdecl *)'

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/openssl -MDd -Zi -RTC1 -W3 -wd4996 -Od -Zm600 -DRUBY_EXTCONF_H="extconf.h" -I. -I./.. -I./../missing -DLIBRUBY_SO="ruby19.dll" -IC:\Development\msvc\include -Foossl_ssl.obj -c -Tc../.././../ext/openssl/ossl_ssl.c ossl_ssl.c
../.././../ext/openssl/ossl_ssl.c(908) : warning C4244: 'function' : conversion from 'time_t' to 'long', possible loss of data

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/openssl -MDd -Zi -RTC1 -W3 -wd4996 -Od -Zm600 -DRUBY_EXTCONF_H="extconf.h" -I. -I./.. -I./../missing -DLIBRUBY_SO="ruby19.dll" -IC:\Development\msvc\include -Foossl_ssl_session.obj -c -Tc../.././../ext/openssl/ossl_ssl_session.c ossl_ssl_session.c
../.././../ext/openssl/ossl_ssl_session.c(110) : warning C4244: 'function' : conversion from 'time_t' to 'long', possible loss of data
../.././../ext/openssl/ossl_ssl_session.c(129) : warning C4244: 'function' : conversion from 'time_t' to 'unsigned long', possible loss of data
../.././../ext/openssl/ossl_ssl_session.c(155) : warning C4244: 'function' : conversion from 'time_t' to 'long', possible loss of data
../.././../ext/openssl/ossl_ssl_session.c(156) : warning C4244: 'function' : conversion from 'time_t' to 'long', possible loss of data

cl -nologo -I. -I../../.ext/include/i386-mswin32_90 -I../.././../include -I../.././../ext/openssl -MDd -Zi -RTC1 -W3 -wd4996 -Od -Zm600 -DRUBY_EXTCONF_H="extconf.h" -I. -I./.. -I./../missing -DLIBRUBY_SO="ruby19.dll" -IC:\Development\msvc\include -Foossl_x509revoked.obj -c -Tc../.././../ext/openssl/ossl_x509revoked.c ossl_x509revoked.c
../.././../ext/openssl/ossl_x509revoked.c(48) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'i2d_of_void (__cdecl *)'
../.././../ext/openssl/ossl_x509revoked.c(64) : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'i2d_of_void (__cdecl *)'
=end

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

=begin
Applied in changeset r22925.
=end