Feature #12639: Speed up require in RubyGems by 5x

• Status: Assigned
• Assignee: hsbt (Hiroshi SHIBATA)
• Target version: -

[segiddins (Samuel Giddins)]

This patch makes requiring an already-loaded file approximated 5x faster when the RubyGems mixin for require is present.
Benchmarked via the following script:

require "rubygems"
require "benchmark/ips"

Benchmark.ips do |x|
	x.report("ruby") { gem_original_require "rubygems" }
	x.report("rubygems") { require "rubygems" }
	
	x.compare!
end

I understand that it's not ideal to add new global functions, and I'd appreciate guidance on where else I could expose this functionality to ruby code.

Thanks :)

[nobu (Nobuyoshi Nakada)]

I'm not sure if it is acceptable for rubygems to skip loaded features.

+VALUE
+rb_f_loaded_feature(VALUE obj, VALUE fname)
+{
+  return rb_provided(RSTRING_PTR(rb_str_encode_ospath(fname))) ? Qtrue : Qfalse;
+}

Why is this function global?
And the argument of RSTRING_PTR should not have side effects.

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned
• Assignee set to hsbt (Hiroshi SHIBATA)