Project

General

Profile

Actions
Copy link

Bug #12130

closed

WEBrick::HTTPProxy closes connection when the socket is not writable temporally

Bug #12130: WEBrick::HTTPProxy closes connection when the socket is not writable temporally

Added by labocho (Keisuke NISHI) over 9 years ago. Updated about 8 years ago.

Status:
Closed
Assignee:
normalperson (Eric Wong)
Target version:
-
ruby -v:
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin14]
Backport:
2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED
[ruby-core:74080]

Description

WEBrick::HTTPProxy#do_CONNECT closes connection when Errno::EAGAIN or Errno::WOULDBLOCK occurred.
These exceptions will raise when the socket is not writable temporally.
I expect that the proxy will wait until the socket will be writable rather than closing the connection.

Files

Download all files
webrick_httpproxy_will_close_connection.patch (805 Bytes) webrick_httpproxy_will_close_connection.patch patch avoids Errno::EAGAIN/Errno::WOULDBLOCK labocho (Keisuke NISHI), 03/01/2016 06:41 AM
webrick_httpproxy_will_close_connection.rb (1.25 KB) webrick_httpproxy_will_close_connection.rb reproduction code labocho (Keisuke NISHI), 03/01/2016 06:42 AM

Updated by hsbt (Hiroshi SHIBATA) about 9 years ago Actions
Copy link
 #1 [ruby-core:77239]

  • Status changed from Open to Assigned
  • Assignee set to hsbt (Hiroshi SHIBATA)

Updated by hsbt (Hiroshi SHIBATA) about 8 years ago Actions
Copy link
 #2 [ruby-core:82861]

  • Assignee changed from hsbt (Hiroshi SHIBATA) to normalperson (Eric Wong)

Eric

Could you review and handle this issue?

Updated by Anonymous about 8 years ago Actions
Copy link
 #3

  • Status changed from Assigned to Closed

Applied in changeset trunk|r59965.

webrick: handle EAGAIN/EWOULDBLOCK on proxy connections

  • lib/webrick/httpproxy.rb (do_CONNECT): high-level IO methods
    [ruby-core:82861] [Bug #12130]
    Patch by: Keisuke NISHI

Updated by hsbt (Hiroshi SHIBATA) about 8 years ago Actions
Copy link
 #4

  • Backport changed from 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED
Actions
Copy link

Also available in: PDF Atom