Project

General

Profile

Actions
Copy link

Bug #12055

closed

`NET::HTTPResponse` is not deflating responses with custom `Content-Range` header

Bug #12055: `NET::HTTPResponse` is not deflating responses with custom `Content-Range` header

Added by ggcampinho (Glauber Campinho) about 10 years ago. Updated over 3 years ago.

Status:
Closed
Assignee:
naruse (Yui NARUSE)
Target version:
-
ruby -v:
2.1.6, 2.2.4
Backport:
2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
[ruby-core:73710]
Tags:
patch, lib

Description

The RFC 7233, section 4.2 describes the the possibility of using a custom Content-Range header and not only for bytes https://tools.ietf.org/html/rfc7233#section-4.2. Although, the NET::HTTPResponse considers that Content-Range present on the response during the inflating is in bytes unit.

This issue is caused by this line https://github.com/ruby/ruby/blob/trunk/lib/net/http/response.rb#L252. In the patch I changed it to check if the Content-Range unit is bytes and there is a test to reproduce the error.

Files

custom_content_range.patch (1.87 KB) custom_content_range.patch ggcampinho (Glauber Campinho), 02/05/2016 01:30 PM

Related issues 1 (0 open — 1 closed)

Is duplicate of Ruby - Bug #11450: HTTPHeader.content_range throws error on non-byte unitsClosedActions

Updated by ggcampinho (Glauber Campinho) about 10 years ago Actions
Copy link
 #1

  • File deleted (custom_content_range.patch)

Updated by ggcampinho (Glauber Campinho) almost 10 years ago Actions
Copy link
 #3 [ruby-core:74645]

Hi! Any thoughts here?

Updated by jeremyevans0 (Jeremy Evans) over 6 years ago Actions
Copy link
 #5 [ruby-core:93392]

  • Status changed from Open to Assigned
  • Assignee set to naruse (Yui NARUSE)

Updated by jeremyevans0 (Jeremy Evans) over 6 years ago Actions
Copy link
 #6

  • Is duplicate of Bug #11450: HTTPHeader.content_range throws error on non-byte units added

Updated by nobu (Nobuyoshi Nakada) over 3 years ago Actions
Copy link
 #7

  • Description updated (diff)

Updated by Anonymous over 3 years ago Actions
Copy link
 #8

  • Status changed from Assigned to Closed

Applied in changeset git|63546bfc1581d4abec2a0d846106a1c0afc0efa9.

HTTPHeader.content_range throws error on non-byte units

  • Added a nil check in Net::HTTPHeader#initialize_http_header for keys in the header that do not have any value
  • Returning nil from the content_range method instead of raising an error when the unit in the content-range header is not bytes
  • Modified initialize_http_header to match trunk

fix [Bug #11450]
fix https://github.com/ruby/ruby/pull/1018

Actions
Copy link

Also available in: PDF Atom