Bug #11663: Segfault when using multiple keywords if the first keyword is invalid

• Status: Closed
• Priority: Normal
• Assignee: -
• Target version: -
• ruby -v: 2.2.3
• Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

[smacgahan (Sean MacGahan)]

When loading a method with an invalid keyword (such as one that ends in a question mark), a syntax error occurs as is expected. However, when loading a method with multiple keywords, if the first keyword is invalid then a segmentation fault occurs.

def foo(arg1?:) end         #=> syntax error
def foo(arg1?:, arg2) end   #=> syntax error (tIDENTIFIER as expected)
def foo(arg1:) end          #=> no syntax error
def foo(arg1:, arg2?:) end  #=> syntax error
def foo(arg1, arg2?:) end   #=> syntax error

def foo(arg1?:, arg2:) end  #=> segfault
def foo(arg1?:, arg2?:) end #=> segfault

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset r52461.

---

parse.y: fix segv after invalid keyword argument

• parse.y (kwd_append): fix segv after invalid keyword argument, preceding keyword list is NULL when syntax error is there. [ruby-core:71356] [Bug #11663]

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)
• Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED

[nobu (Nobuyoshi Nakada)]

• Related to Feature #10440: Optimize keyword and splat argument added

[nobu (Nobuyoshi Nakada)]

• Related to Bug #10545: SEGV: def m(A: a) end added

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

Backported into ruby_2_2 branch at r52742.