Project

General

Profile

Actions

Feature #11137

closed

[PATCH] webrick: remove redundant close-on-exec setting

Added by normalperson (Eric Wong) about 10 years ago. Updated about 10 years ago.

Status:
Closed
Target version:
-
[ruby-core:69127]

Description

  • lib/webrick/server.rb: avoid redundant fcntl call

Sockets are close-on-exec by default since Ruby 2.0, so it
is redundant to set it again.


Files

Updated by normalperson (Eric Wong) about 10 years ago

Same for drb.

If no response, I'll commit this along with patch in #11136 in a week unless
there's some reason to keep compatibility in stdlib with old Rubies.

Actions #2

Updated by Anonymous about 10 years ago

  • Status changed from Open to Closed

Applied in changeset r50519.


lib/webrick/server.rb: avoid redundant fcntl call

Sockets are close-on-exec by default since Ruby 2.0, so it
is redundant to set it again.

  • lib/webrick/server.rb (accept_client): avoid redundant fcntl call
    [Feature #11137]
Actions

Also available in: Atom PDF

Like0
Like0Like0