Project

General

Profile

Feature #11081

[PATCH] stdlib: use IO#wait_*able instead of IO.select when possible

Added by normalperson (Eric Wong) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:<unknown>]

Description

In case a process encounters high-numbered FDs, this allows
consistent performance on systems with ppoll support.
[ruby-core:35572]

  • ext/socket/lib/socket.rb (connect_nonblock): use IO#wait_writable
  • lib/drb/drb.rb (DRB::DRbTCPSocket#alive?): use IO#wait_readable
  • lib/webrick/httpserver.rb (run): ditto
  • lib/resolv.rb (request): ditto for single socket case

Pretty trivial since io/wait seems supported everywhere nowadays.
Any objections?


Files

#1

Updated by Anonymous over 5 years ago

  • Status changed from Open to Closed

Applied in changeset r50432.


stdlib: use IO#wait_*able instead of IO.select when possible

In case a process encounters high-numbered FDs, this allows
consistent performance on systems with ppoll support.
[ruby-core:35572]

  • ext/socket/lib/socket.rb (connect_nonblock): use IO#wait_writable
  • lib/drb/drb.rb (DRB::DRbTCPSocket#alive?): use IO#wait_readable
  • lib/webrick/httpserver.rb (run): ditto
  • lib/resolv.rb (request): ditto for single socket case [ruby-core:68943] [Feature #11081]

Also available in: Atom PDF