Bug #11045: ruby/test_m17n_comb.rb test_str_crypt tests platform-specific crypt behavior

• Status: Closed
• Assignee: headius (Charles Nutter)
• Target version: -
• ruby -v: trunk
• Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

[headius (Charles Nutter)]

I think we should just remove the glibc version guards in test_str_crypt in test/ruby/test_m17n_comb.rb.

1. JRuby can't determine glibc version without making a glibc-specific call (because we have no build-time configure script or similar)
2. On platforms that use glibc but don't report version, this guard won't work.
3. Do we really want to be testing linux-specific crypt behavior?

I propose that we just make the test skip non-alpha salt unconditionally.

[nobu (Nobuyoshi Nakada)]

Charles Nutter wrote:

3. Do we really want to be testing linux-specific crypt behavior?

I don't think we want, it's just an implementation regression test.

I propose that we just make the test skip non-alpha salt unconditionally.

Or we need a standard way to isolate this kind of tests.

[headius (Charles Nutter)]

Nobuyoshi Nakada wrote:

Or we need a standard way to isolate this kind of tests.

That's not a bad idea, actually. I will split the Linux-specific regression part into a separate test. JRuby uses excludes to mask tests, so that will allow us to exclude the platform-specific one.

[headius (Charles Nutter)]

• Status changed from Open to Closed

Fixed by r50366.

[headius (Charles Nutter)]

• Assignee set to headius (Charles Nutter)

[usa (Usaku NAKAMURA)]

• Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED

[usa (Usaku NAKAMURA)]

• Backport changed from 2.0.0: WONTFIX, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

Backported into ruby_2_2 branch at r51130.